search

radondb / radon

RadonDB is an open source, cloud-native MySQL database for building global, scalable cloud services
https://radondb.io/
GNU General Public License v3.0
1.79k stars 218 forks source link

*: fix bug explain has problem of escaping characters #706 #707

Closed zhyass closed 3 years ago

zhyass commented 3 years ago

[summary] Use an Encoder by calling SetEscapeHTML(false) to avoid the mistake.

[test case] src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/depends/common/unsafe_test.go

[patch codecov] src/vendor/github.com/xelabs/go-mysqlstack/sqlparser/depends/common/unsafe.go 94.4%

codecov[bot] commented 3 years ago

Codecov Report

Merging #707 (1e0fefc) into master (db58827) will decrease coverage by 0%. The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #707   +/-   ##
=====================================
- Coverage      89%    88%   -1%     
=====================================
  Files         130    130           
  Lines        9277   9277           
=====================================
- Hits         8257   8252    -5     
- Misses        677    680    +3     
- Partials      343    345    +2
Impacted Files Coverage Δ
src/planner/builder/aggregate_plan.go 94% <100%> (ø)
src/planner/builder/limit_plan.go 86% <100%> (ø)
src/planner/builder/orderby_plan.go 96% <100%> (ø)
src/planner/ddl_plan.go 90% <100%> (ø)
src/planner/delete_plan.go 92% <100%> (ø)
src/planner/insert_plan.go 93% <100%> (ø)
src/planner/others_plan.go 92% <100%> (ø)
src/planner/select_plan.go 97% <100%> (ø)
src/planner/union_plan.go 95% <100%> (ø)
src/planner/update_plan.go 92% <100%> (ø)
... and 3 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update db58827...1e0fefc. Read the comment docs.