radondb / xenon

The MySQL Cluster Autopilot Management with GTID and Raft
GNU General Public License v3.0
693 stars 162 forks source link

*: add http api for adapt kubernetes #139

Closed zhyass closed 3 years ago

zhyass commented 3 years ago

[summary] By using api can fix the kubernetes container memory increase unexpected bug.

https://github.com/zhyass/mysql-operator/issues/17

Before: https://github.com/zhyass/mysql-operator/blob/master/cluster/syncer/status.go#L270

memory: 230+ M

After:

https://github.com/zhyass/radondb-mysql-kubernetes/blob/meg/cluster/syncer/status.go#L281

memory: 17M

codecov[bot] commented 3 years ago

Codecov Report

Merging #139 (d317153) into feature_adapt_k8s (88c1a8a) will increase coverage by 0%. The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff                @@
##           feature_adapt_k8s   #139   +/-   ##
================================================
  Coverage                 68%    68%           
================================================
  Files                     48     48           
  Lines                   3744   3749    +5     
================================================
+ Hits                    2558   2563    +5     
  Misses                   954    954           
  Partials                 232    232           
Impacted Files Coverage Δ
src/config/config.go 80% <100%> (+<1%) :arrow_up:
src/server/server.go 52% <100%> (+1%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 88c1a8a...d317153. Read the comment docs.

hustjieke commented 3 years ago

radondb:feature_adapt_k8s should merge commits with main feature first.

zhyass commented 3 years ago

radondb:feature_adapt_k8s should merge commits with main feature first.

The main feature has been merged.

hustjieke commented 3 years ago

LGTM.

dbkernel commented 3 years ago

Advice:

  1. Add security authentication
  2. Add configuration items to set whether or not the RESTful API is enabled
zhyass commented 3 years ago

Advice:

1. Add security authentication

2. Add configuration items to set whether or not the RESTful API is enabled

Done.

dbkernel commented 3 years ago

LGTM

andyli029 commented 3 years ago

LGTM.