search

radpointhq / orthanc-s3-storage

S3 Storage Plugin - A plugin for Orthanc DICOM Server for storing DICOM data in Amazon Simple Storage Service (AWS S3).
GNU Affero General Public License v3.0
50 stars 25 forks source link

Plugin does not abide by "StoreDicom" : "false" configuration option #15

Open jasperdenotter opened 4 years ago

jasperdenotter commented 4 years ago

Hello,

I have recently been using this plugin to use Orthanc while saving disk space by storing all DICOM files in S3 storage, it works great! I have a question regarding the "index-only" mode on Orthanc and it's compatibility with this plugin; at the moment it looks like the plugin disregards the "StoreDicom" configuration option and always stores the entire DICOM file in S3. Would it be possible to modify the plugin to listen to this configuration option so that when "StoreDicom" is set to "false" only the JSON summary of the DICOMs is stored and not the entire file?

I tested this by setting "StoreDicom" to false, uploading some files, and then checking if I could still view them on the osimis web viewer. In this Case I was able to still see the full images were being stored. Let me know how involved it would be to make this change and if this is something you would consider implementing. I'd be happy to answer any questions you have.

Thanks!

gmanuel-vitall commented 4 years ago

Hi @jasperdenotter I am trying to run the dockerfile to get this running but am getting an error statement Error libcrypto.so.1.0.0: cannot open shared object file: No such file or directory. Did you ever come across this issue and if so, how did you resolve it?

Thanks!

bpycinski commented 4 years ago

Hi @jasperdenotter, thanks for being interested in Orthanc and sorry for a late response. Previously we had distinguished dicoms from jsons, this was removed with a commit https://github.com/radpointhq/orthanc-s3-storage/commit/7ebd9b32c643dedf5e80e84e17e28ec20f0ab2de . But you can easily switch the condition to store only jsons on s3.