Unnecessary assignment (?)

radu-matei / websocket-manager

Real-Time library for ASP .NET Core

MIT License

452 stars 183 forks source link

Closed sarmis closed 6 years ago

sarmis commented 6 years ago

It's a minor issue but I think that line 52 is unnecessary (List is referenced type and does not need to be reassigned to itself)

If that is true and I'm not missing something the above three lines can be replaced by:
```
_groups[groupID].Add(socketID);
```

radu-matei commented 6 years ago

cc @miker1423, who actually implemented the groups API.

Thanks!

miker1423 commented 6 years ago

yes, its unnecessary, I'll fix it ASAP.

miker1423 commented 6 years ago

ready, can someone review the fix? is PR #55

radu-matei commented 6 years ago

Closing this as of #55. Thanks a lot for your contribution!