search

raduprv / Eternal-Lands

http://www.eternal-lands.com
Other
158 stars 57 forks source link

Map Editor: Remove "Eye Candy" button #102

Closed feeltheburn closed 3 years ago

feeltheburn commented 3 years ago

The "eye candy" does not work, and I doubt it ever will at this point. I don't think it'll be of any benefit to make it work now either.

The button for it is confusing to those trying to learn the editor. Even I thought it was how particles were added at first before digging through the forum and learning how to actually do particles.

This button should be removed. Or I guess more appropriately, only show in an "#ifdef EYE_CANDY" condition.

eyecandybutton

gvissers commented 3 years ago

Huh, not having worked with the map editor in possibly decades, I assumed this was actually how particle systems were added to the map, and that the fourth button was for "old-fashioned" particle systems only. The "old" particle systems are actually mapped to "new" particle systems in the client code.

I will probably have a look at this later, see if I can figure out what it's supposed to do.

feeltheburn commented 3 years ago

It's hosed, whatever it's supposed to do.

I've worked extensively on every non-guild map in the game over the past 5 or so years, between that and writing scripts that auto-generate maps and map debugging images, I can 100% say all particles on current maps are from what's found in the particles button.

The eye candy was supposed to do odd crap like wind blowing leaves, much more advanced than anything on any map. And would probably kill the android client if used, heh.

THE CLIENT CRASHES! If you put some eye candy on the map, like the aforementioned leaves.

And oh yeah, there's serious issues with trying to delete an eye candy when placed.

There's just nothing about it that screams "stable". I wouldn't accept any map to be put on the server that has this eye candy on it.

gvissers commented 3 years ago

Ok, the eye candy button should no longer show up if the editor is not compiled with EYE_CANDY defined.

feeltheburn commented 3 years ago

Works.

The Makefile.win and Makefile.linux files should probably be updated to not have EYE_CANDY compiled by default. Just a quick fix near the top of each file.

gvissers commented 3 years ago

Oh yeah, I mistakenly assumed that was the default. Corrected.