raduprv / Eternal-Lands

http://www.eternal-lands.com
Other
158 stars 57 forks source link

Fix DROP_ITEM message_length in quickbar #105

Closed brunoramoslu closed 3 years ago

brunoramoslu commented 3 years ago

Fix DROP_ITEM message_length in quickbar

When doing a ctlr + left click to drop all from the quick bar the the DROP_ITEM message length was set to 4 causing item quantity to misbehave. The fix sets the DROP_ITEM message length to 6 like all the other DROP_ITEM messages in the code.

State before drop all from quick bar (ctrl + left click) inventory-quickbar-before-drop-all-in-quickbar State after drop all from quick bar (ctrl + left click) inventory-quickbar-bag-after-drop-all-in-quickbar

gvissers commented 3 years ago

It's a bloody miracle the server accepted the short count. Good find! Merged, and thanks.

EDIT: Let me amend that: it is not only a miracle. It is, frankly, rather disturbing.