raduprv / Eternal-Lands

http://www.eternal-lands.com
Other
157 stars 57 forks source link

Map Editor: Add 2D objects browser #114

Open brunoramoslu opened 3 years ago

brunoramoslu commented 3 years ago

Idea from Burn tutorial videos

brunoramoslu commented 2 years ago

So I'm going back to some of the map editor issues again, this is on my radar for a possible pull request in the near future. I still need to get a bit more familiar with the map editor code.

Any ideas on how to implement the 2d object browser are most welcome. :slightly_smiling_face:

I assume something really simple like the 3d object browser would be enough for a start.

gvissers commented 2 years ago

I still need to get a bit more familiar with the map editor code.

TBH, I think nobody is familiar with the map editor code :laughing: And TB brutally H, I think we mostly just keep it limping along. For actual use, you'd want to talk to Burn. For coding the map editor, well, I'm always more than happy to help, but oftentimes you'd be quicker just figuring it out yourself.

I suppose you could use the 3D browser as a base, though I would appreciate it if you could use more descriptive variable names than the ones used there. And make objects static if only used in that particular source file. And use loops instead of copy-paste to the n-th degree. And use symbolic constants instead of numeric literals all over the place. And while you're at it, make that particular new window also scalable with a global UI scale factor so I can read the text in it.

That's my wishlist for the time being. I'm sure more will follow :rofl: