raduprv / Eternal-Lands

http://www.eternal-lands.com
Other
158 stars 57 forks source link

Fix water reflection on Windows/Virtualbox/Intel graphics #167

Closed gvissers closed 2 years ago

gvissers commented 2 years ago

Fix a number of issues with the water reflection running the client on a Windows client in Virtualbox:

Posting this as a pull request, so that people may check if it does not have any unwanted side effects. As far as I can tell, there should be none: the first fix should not affect properly behaving systems, and the second just rewrites the same assignment in separate components. I have tested this also in Linux, which was working correctly before, and have observed no change in behaviour. Nevertheless, better get some other testing in before we break an existing setup.

pjbroad commented 2 years ago

It does not appear break the nice water ripples and reflections for my main machine Linux + nvidia; which is good. I'll check on a few other machines when I have time, including and ancient AMD laptop running Windows which does work OK currently.

gvissers commented 2 years ago

Great, thanks for testing!