raduprv / Eternal-Lands

http://www.eternal-lands.com
Other
155 stars 56 forks source link

Can we remove UVP: 1 now? #183

Closed feeltheburn closed 2 years ago

feeltheburn commented 2 years ago

This seems more like a debug text than a necessity. It can easily be determined by checking the settings, and is not something the player needs to constantly see.

Maybe it was necessary "back in the day", but perhaps we can get rid of the "UVP: 1" line when showing FPS now?

Screenshot_20220321_131106

gvissers commented 2 years ago

Does that option even work for you? It just makes the characters disappear on my system. Does it make a difference if you enable it? The animation shader is written in a very old shader assembly language, not many systems seem to support it anymore. I've been thinking about rewriting it in GLSL, but haven't worked on it yet.

Anyways, I agree, the text is pointless. I've moved it under the DEBUG compile option, normal players should not see it anymore.

pjbroad commented 2 years ago

If you exit with it enabled, your character should be visible when you restart. I have it disabled because it makes your eyes look weird. I briefly looked into why that was but could not find a solution. Disabling it does not appear to impact performance as far as I can tell.

raduprv commented 2 years ago

Normally there is not much of a difference with UVP on, but in invasions there's quite a difference.

gvissers commented 2 years ago

If you exit with it enabled, your character should be visible when you restart.

Hmm... That works somewhat, but the texturing is gone: uvp

Normally there is not much of a difference with UVP on, but in invasions there's quite a difference.

Okay, that makes sense. I'll see if I can translate the shader to GLSL at some point.

raduprv commented 2 years ago

That would be great!

feeltheburn commented 2 years ago

I've had UVP on (1) since as far back as I can remember, turning it off and on has no effect here.

But thanks, my reason for posting this is done. Y'all seem to be discussing other related stuff so I'll leave it open. You can close it if/when the other talk's done. :)

feeltheburn commented 2 years ago

I'll close this to clean up clutter. (If this extended stuff needs discussion a new issue may be better suited for it.)