Green watery gunk becomes regular water when reflections on

[feeltheburn]

As can be seen, this rarely used green watery-type ground tile turns into regular water when reflections are turned on.

[feeltheburn]

https://github.com/raduprv/Eternal-Lands/pull/194

Submitted a pull request that fixes it.

As seen below, the green gunk remains the same with reflections on, just like lava and dirty waters. All water types are displayed, showing the fix does not affect any of them.

(Leonard is also impressed with the results.)

[gvissers]

If I'm seeing the first picture correctly, it doesn't turn into a regular water tile, but a slightly greenish water (compare it with regular water in the lower right). I will admit that I had expected the effect of the water texture to be stronger, though, also for the tile under the lava. Fix looks fine to me, if you are happy with water tiles 233-239 not reflecting.

[feeltheburn]

234-239 do not exist, and pretty much zero chance they ever will with there being no use for them as the maps are at a pretty much set state.

If a new reflective water gets added, testing it will show this file needs to change with it, and it would be better to number it in the 221-229 fields, changing #define IS_WATER_TILE(i) (!i || (i>230 && i<255)) to i>220.

There is a very, very slight difference in water color with the current version, but this water is obviously meant to be more like some kind of... I wanna say radioactive gunk? But it does seem it should behave more like the dirty water, with no change.

[feeltheburn]

This is the lower end of the tiles as shown in the map editor. Unseen "0" at the very top is the most commonly seen water, then there's the 6 "water" tiles seen here in the 200s. All 7 total are seen in the above images.

As the white areas show, there's a wealth of unused numbers.

[feeltheburn]

Closing as the commit solves the issue.