raduprv / Eternal-Lands

http://www.eternal-lands.com
Other
159 stars 57 forks source link

Git submodules for EL data and encyc? #212

Open lukehorvat opened 5 months ago

lukehorvat commented 5 months ago

Hi, I've been taking a bit of a closer look at some of the actor data files lately and the thought occurred to me that it would be nice to see the git history of some of the files to see how they arrived in their current state, but that info is currently not available to me. Are these assets maintained in a private repo somewhere?

Given that the data files are a critical part of the client build, perhaps they could be added to the repo itself so they are version controlled just like the code is? Has this been discussed before? If the concern is that adding them directly to this repo will bloat it, then they could be hosted in a separate repo and included here as a git submodule.

Same applies to the el-encyc. That could be included as a submodule too.

raduprv commented 5 months ago

Those haven't been modified in a long while, and it's unlikely they will be modified again soon, so I don't see any benefit of adding them to github.

feeltheburn commented 4 months ago

The data files have been kept in a private GIT due to there being restrictions on a lot of its use, per the EL license .

I maintain that private GIT on Gitlab, bluap and acelon have access to it. Very little normally changes between client releases. For the coming 1.9.7, these are the changes:

A zip of the files is provided for those doing official builds, by either myself or bluap.


Map files are kept in yet another separate private GIT. Only Acelon and I have access because it includes server-side def files.

(Tab maps are kept nowhere, I have scripts that I use to automatically build them just before release.)


The encyclopedia is separate, in a GIT run by Sir-Odie. It's not been touched in years. That's what's in the client, though.

(I was actually considering doing some kind of automated build of the encyclopedia using my data on the https://el-db.com website, that would ensure it was up to date, but ugh the amount of coding involved in that. Not to mention I could only update English.)

feeltheburn commented 1 month ago

(There's nothing to be done with this, so it's closeable.)