raduprv / Eternal-Lands

http://www.eternal-lands.com
Other
158 stars 57 forks source link

Items in multiple sto categories should not show when traded #61

Open feeltheburn opened 5 years ago

feeltheburn commented 5 years ago

When storage trading, if you put all of an item into the trade window, it stops showing in your storage window.

(i.e. you have 10 daffodils, you put all 10 in trade window and they immediately no longer show in the storage)

However, if you trade something that's in multiple categories (examples: bones are in Animal and Weapons, low-level leather stuff is in Armor and Clothes) this does not happen.

(i.e. you have 2 leather boots, you put both in the trade window, it still shows 2 leather boots in storage)

This is not that important of course, but it would be great if these could disappear from sto window like other items while trading. (I notice it since I trade bones a lot with alts and I have to actually look to see if all the bones are in the trade window.)

EDIT: As well, when ALL of one of these objects are placed into the trade window, the object remains attached to the cursor, which doesn't happen for objects in single categories.

pjbroad commented 5 years ago

@raduprv This may be a server issue. For the trades that do not show the storage update, the trader shows GET_TRADE_REJECT followed by GET_TRADE_OBJECT. For trades that do show the update we get GET_TRADE_REJECT, followed by STORAGE_ITEMS then GET_TRADE_OBJECT.

feeltheburn commented 5 years ago

Usually left-click to get the item off the cursor.

But yeah, that missing "STORAGE_ITEMS" could be the culprit. When you change to look at a different category, then go back to the category in question with all of the item in the trade window, it will be gone from the storage view.

(Attaching an image for reference just to show the issue directly. Leather Gloves are in both Armor and Tools.)

TRADE