Nimic important- Ignor

[roxanaN]

Le-am verificat si merg toate. Am facut si restul modificarilor, dar nu mai pot incarca nimic, fiindca la final imi apare asta:

​

2018-03-22 1:22 GMT+02:00 Radu Stochitoiu notifications@github.com:

@radusqrt commented on this pull request.

Pune comentarii si in Doolittle ca in Crout. Also, da un git rm pe doolittle.m si crout.m scrise cu litera mica daca vrei sa nu le adaugi in pull request. De asemenea, le-ai verificat? Merg sigur?

In MN/Algoritmi/Algoritmi-ad-hoc/SIT.m https://github.com/radusqrt/help-the-kids/pull/6#discussion_r176268898:

@@ -0,0 +1,25 @@ +function [x] = SIT(A, b)

• % if the matrix is not lower triangular, we cannot solve the system
• % tril(A, -1) gets us what is strictly under the main diagonal
• % max(matrix) gets us a list of every column's max
• % max(list) gets us the maximum from the list
• if max(max(abs(tril(A', -1)))) > eps

in loc sa faci tril(A', -1) nu poti face triu(A, -1) ca sa nu confuzam pe nimeni care citeste sursa? asta ar insemna sa modifici in comentariu mai sus tril in triu

In MN/Algoritmi/Algoritmi-ad-hoc/SIT.m https://github.com/radusqrt/help-the-kids/pull/6#discussion_r176269183:

@@ -0,0 +1,25 @@ +function [x] = SIT(A, b)

• % if the matrix is not lower triangular, we cannot solve the system
• % tril(A, -1) gets us what is strictly under the main diagonal
• % max(matrix) gets us a list of every column's max
• % max(list) gets us the maximum from the list
• if max(max(abs(tril(A', -1)))) > eps
• disp('The matrix A is not lower triangular!');
• x = NaN;
• return;
• endif
• n = length(b);

nu mai lasa newline aici. sunt legate logic n = length si x = zeros. amandoua sunt initializari, deci trebuie sa stea in acelasi bloc logic.

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/radusqrt/help-the-kids/pull/6#pullrequestreview-105942122, or mute the thread https://github.com/notifications/unsubscribe-auth/Aj38RawN46KTULKWzlcus7gUYdLZMyPfks5tguCggaJpZM4S1c5P .

[radusqrt]

Fa un alt branch. Copiaza-le pe toate acolo si creeaza un nou PR cu ele. Ai sters branch-ul si nu mai pot eu sa ii dau reopen.