search

radvd-project / radvd

radvd | Official repository: https://github.com/radvd-project/radvd
https://radvd.litech.org/
Other
203 stars 106 forks source link

Fix case of AdvValidLifetime option #184

Closed oskar456 closed 2 years ago

oskar456 commented 2 years ago

In the manual page, the NAT64 Lifetime option is presented as AdvValidLifeTime, while the only accepted input is with lower case T: AdvValidLifetime.

This fixes the documentation. Please note that there is still some inconsistency, as ABRO still uses LifeTime with capital T and have it recognized as a separate token.

Signed-off-by: Ondřej Caletka ondrej@caletka.cz

Neustradamus commented 2 years ago

@robbat2, @stappersg: What do you think?

robbat2 commented 2 years ago

How about making the code be case-insensitive for this?

Neustradamus commented 2 years ago

@oskar456: Have you seen the @robbat2 comment?

oskar456 commented 2 years ago

@oskar456: Have you seen the @robbat2 comment?

I've seen that, yes. I'm not sure whether I should be the one doing this as I have zero experience with yacc. My tension here is just to make copy-pasted example from the manual page work. Maybe this pull request does not go far enough, but I still feel like it makes progress in the right direction.

robbat2 commented 2 years ago

Have a look at https://github.com/radvd-project/radvd/pull/187 that should supersede your PR.

oskar456 commented 2 years ago

Awesome, thanks! This can be closed then.