search

radvd-project / radvd

radvd | Official repository: https://github.com/radvd-project/radvd
https://radvd.litech.org/
Other
203 stars 106 forks source link

Add missing configure check for AM_PROG_AR #188

Closed kepstin closed 2 years ago

kepstin commented 2 years ago

The automake build generates a static convenience library (libradvd_parser.a) but the configure script does not include a check for the 'ar' program used to generate that library. Without any check, automake ends up using the tool 'ar' as a fallback.

This fails in some distro packaging or cross-compiling environments where a specific prefixed 'ar' tool is needed.

Adding the AM_PROG_AR makes the configure script autodetect the prefixed ar tool in a way that's compatible with normal distro packaging and cross compiling tooling.

robbat2 commented 2 years ago

Thanks, running CI on this before merge

stappersg commented 2 years ago

CI did run fine.