search

radvd-project / radvd

radvd | Official repository: https://github.com/radvd-project/radvd
https://radvd.litech.org/
Other
203 stars 107 forks source link

Makefile.am: drop -Wno-implicit-function-declaration #196

Closed thesamesam closed 2 years ago

thesamesam commented 2 years ago

  1. Clang 16 makes -Wimplicit-function-declaration error by default (and it's planned that GCC 14 will do the same) so we need to fix the real problem. This is papering over it.

  2. It's not true that there's nothing we can do about it. Fix in a follow-up commit.

Fixes: b5e6b09 Signed-off-by: Sam James sam@gentoo.org

thesamesam commented 2 years ago

Thanks for the quick review. Bonus is that this may well have helped with https://github.com/radvd-project/radvd/issues/158.

robbat2 commented 2 years ago

We need to fix the CI so FreeBSD passes: https://github.com/radvd-project/radvd/pull/198