netlink: cleanup interfaces upon removal

radvd-project / radvd

radvd | Official repository: https://github.com/radvd-project/radvd

https://radvd.litech.org/

Other

203 stars 107 forks source link

netlink: cleanup interfaces upon removal #229

Open xdbob opened 9 months ago

xdbob commented 9 months ago

Previously, when an interface was removed radvd did not release it's multicast membership leaking kernel resources leading to a potential out of memory failure of the setsockopt([...], IPV6_ADD_MEMBERSHIP, [...]) call.

Fixes #228

xdbob commented 7 months ago

@robbat2 did you have time to look ? as a side-note the code is running on multiple thousand of machines since late February without issue yet

Neustradamus commented 3 months ago

@reubenhwk: What do you think?

reubenhwk commented 2 months ago

I've look over the change and I agree that it is correct. It should be merged.

robbat2 commented 2 months ago

Why did the CI not run for the PR?