radvd-project / radvd

radvd | Official repository: https://github.com/radvd-project/radvd
https://radvd.litech.org/
Other
203 stars 107 forks source link

don't close config file pointer #38

Closed reubenhwk closed 8 years ago

reubenhwk commented 10 years ago

The config file doesn't change name from start to finish, but the permissions and uid of radvd can. Open the config file, but never close it. Test changing the file, and re-reading it. Test changing permissions in an insecure way and make sure radvd fails and exits.

On my system, radvd frequently dies because of broken default permissions.

Nov 05 08:02:19 netz UNKNOWN[27217]: attempting to reread config file Nov 05 08:02:19 netz UNKNOWN[27217]: can't open /etc/radvd.conf: Permission denied Nov 05 08:02:19 netz radvd[27215]: Exiting, privsep_read_loop had readn return 0 bytes

https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=728787

reubenhwk commented 8 years ago

closing this issue because permissions on radvd.conf should not be so restrictive.