search

radxa-pkg / radxa-overlays

Additional device tree overlays to support different hardwares on Radxa products
GNU General Public License v2.0
39 stars 28 forks source link

rockchip: add watch dog support #252

Closed nascs closed 8 months ago

nascs commented 8 months ago

Signed-off-by: Nascs Fang nascs@radxa.com

rk3399, 用的是 4C+ 做的测试， rk356x 用的是 CM3-IO， rk3588 用的是 5B

nascs commented 8 months ago

测试参考的是 https://blog.csdn.net/weixin_43245753/article/details/124269920

nascs commented 8 months ago

其实你是不是可以创建一个rockchip-watchdog.dts啊，然后把这些soc都放到compatible里面 顺便看看3308和3328有没有wdt

确实

nascs commented 8 months ago

其实你是不是可以创建一个rockchip-watchdog.dts啊，然后把这些soc都放到compatible里面 顺便看看3308和3328有没有wdt

这样的话，Makefile 也要单独开一个类似于 "dtb-$(CONFIG_CPU_RK3588) += \" 的集合？

RadxaYuntian commented 8 months ago

可以在Makefile里面加一个dtb-y += rockchip-watchdog.dtbo

nascs commented 8 months ago

mainline 的节点是 watchdog， https://github.com/torvalds/linux/blob/99bd3cb0d12e85d5114425353552121ec8f93adc/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi#L2192C4-L2192C12

RadxaYuntian commented 6 months ago

所以为什么overlay在Makefile里面单独加了个dtb-y啊！

nascs commented 6 months ago

所以为什么overlay在Makefile里面单独加了个dtb-y啊！

https://github.com/radxa/overlays/pull/252#issuecomment-1929048963

RadxaYuntian commented 6 months ago

当时说的是给rockchip，amlogic本身只有一个target就没必要这么做。我刚刚看到rock 5b的内核现在也包含了amlogic的overlay

回头我看看怎么处理比较好