radxa / u-boot

U-Boot tree for pending commits
43 stars 90 forks source link

Add rock5a nvme boot support #23

Closed amazingfate closed 1 year ago

RadxaStephen commented 1 year ago

We cannot enable spi nor flash and eMMC at the same time. See this commit. https://github.com/radxa/u-boot/commit/6cb48b3786a3430afbb3219d6170ee9fe0878599

By default we want eMMC bootimg. Can you disable nodes sfc and spi_nor?

Thanks.

amazingfate commented 1 year ago

I forgot that I've disabled emmc in device tree when tesing. Emmc and spi flash are both installed as a removable module so they can't get installed to board at the same time. Can the uboot driver itself auto detect if there is emmc or spi flash installed on board?

RadxaStephen commented 1 year ago

You can disable nodes sfc and spi_nor and keep nvme related nodes. And we can support

For SPI + nvme and SPI + USB, We need to add another commit to enable sfc and spi_nor nodes and disable sdhci.

RadxaStephen commented 1 year ago

I forgot that I've disabled emmc in device tree when tesing. Emmc and spi flash are both installed as a removable module so they can't get installed to board at the same time. Can the uboot driver itself auto detect if there is emmc or spi flash installed on board?

I think when you enable spi and emmc at the same, pinctrl driver would show error.

amazingfate commented 1 year ago

Force pushed, now it only has pci related changes.

amazingfate commented 1 year ago

@RadxaStephen @RadxaYuntian Refering to the implementation from orangepi5 which distinguish pcie and sata with two uboot device trees: https://github.com/orangepi-xunlong/u-boot-orangepi/commit/cdbf9851cdedffc9f0abda395da72d5292cc31e9, I add one more defconfig and devicetree for spi flash.

amazingfate commented 1 year ago

Build with armbian build framework seems okay: https://paste.next.armbian.com/eyutetofiv

amazingfate commented 1 year ago

Tested with spi flash module + nvme ssd and emmc, armbian is booting fine.

RadxaStephen commented 1 year ago

Thanks. I tested eMMC + NVME. It works.

And would you mind changing your git message?

Here are some rules:

RadxaStephen commented 1 year ago

Great. Thanks.

stevepringle commented 1 year ago

Hi, is there any timescale for adding usb3.0 boot support to this?