search

radxa / u-boot

U-Boot tree for pending commits
43 stars 90 forks source link

update defconfig for cm5io and cm5 rpi cm5 io #36

Closed Ken-Vamrs closed 1 year ago

RadxaYuntian commented 1 year ago

35 还禁止了CONFIG_ROCKCHIP_SET_ETHADDR。你现在系统的mac行为是怎样的

Ken-Vamrs commented 1 year ago

35 还禁止了CONFIG_ROCKCHIP_SET_ETHADDR。你现在系统的mac行为是怎样的

35 没有禁止，只是多加了注释，我用make savedefconfig 更新的defconfig

现在系统的mac行为是更新了uboot，以太网mac固定，重新刷emmc后也是一样的mac地址，同一个sd卡在不同的板子上识别到的以太网地址不会重复是唯一的。

RadxaYuntian commented 1 year ago 
[excalibur@yuntian u-boot]$ git switch -c cm5_ken ken/next-dev 
branch 'cm5_ken' set up to track 'ken/next-dev'.
Switched to a new branch 'cm5_ken'
[excalibur@yuntian u-boot]$ make radxa-cm5-io-rk3588s_defconfig
  HOSTCC  scripts/basic/fixdep
  HOSTCC  scripts/kconfig/conf.o
  SHIPPED scripts/kconfig/zconf.tab.c
  SHIPPED scripts/kconfig/zconf.lex.c
  SHIPPED scripts/kconfig/zconf.hash.c
  HOSTCC  scripts/kconfig/zconf.tab.o
In file included from scripts/kconfig/zconf.tab.c:2470:
In function ‘dep_stack_insert’,
    inlined from ‘sym_check_print_recursive’ at scripts/kconfig/symbol.c:1123:3,
    inlined from ‘sym_check_deps’ at scripts/kconfig/symbol.c:1300:3:
scripts/kconfig/symbol.c:1099:19: warning: storing the address of local variable ‘cv_stack’ in ‘check_top’ [-Wdangling-pointer=]
 1099 |         check_top = stack;
      |         ~~~~~~~~~~^~~~~~~
scripts/kconfig/symbol.c: In function ‘sym_check_deps’:
scripts/kconfig/symbol.c:1120:26: note: ‘cv_stack’ declared here
 1120 |         struct dep_stack cv_stack;
      |                          ^~~~~~~~
scripts/kconfig/symbol.c:1090:4: note: ‘check_top’ declared here
 1090 | } *check_top;
      |    ^~~~~~~~~
  HOSTLD  scripts/kconfig/conf
#
# configuration written to .config
#
[excalibur@yuntian u-boot]$ grep CONFIG_ROCKCHIP_SET_ETHADDR .config 
CONFIG_ROCKCHIP_SET_ETHADDR=y
[excalibur@yuntian u-boot]$ git switch -c nx5_feng feng/next-dev 
branch 'nx5_feng' set up to track 'feng/next-dev'.
Switched to a new branch 'nx5_feng'
[excalibur@yuntian u-boot]$ make radxa-nx5-io-rk3588s_defconfig
#
# configuration written to .config
#
[excalibur@yuntian u-boot]$ grep CONFIG_ROCKCHIP_SET_ETHADDR .config 
# CONFIG_ROCKCHIP_SET_ETHADDR is not set
Ken-Vamrs commented 1 year ago

ok, 我重新改一下

RadxaYuntian commented 1 year ago

但问题是如果你不禁用CONFIG_ROCKCHIP_SET_ETHADDR也能得到我们想要的行为的话，那么禁用后要重测，并且评估有没有必要禁止这个功能

Ken-Vamrs commented 1 year ago

但问题是如果你不禁用CONFIG_ROCKCHIP_SET_ETHADDR也能得到我们想要的行为的话，那么禁用后要重测，并且评估有没有必要禁止这个功能

我昨天验证的时候是有禁用CONFIG_ROCKCHIP_SET_ETHADDR的，只是刚刚在提交的时候我以为只是注释作用而已就没有加上