[calendar] - Event notifications (timezone offset)

[GoogleCodeExporter]

Token: 4fabbd4e5b4fd38339bcabc59e3b15be (Don't modify this token!)
Version: 17.0.3 (11-01-2014)
PHP: 5.3.28
RCMAIL: 0.9.5
Database: mysql
SERVER: Apache
----
I.  Issue Description:
When I create an event in the calendar, I set up the start and end time. It 
shows correctly on the calendar page. The email I receive with the ICS file has 
the wrong time!
I created thie event for 16:30 but inside my email i had:

Oggetto:    qqqqqqq
Descrizione:    qqqqqqq
Inizio: 16/01/2014 15:30
Fine:   16/01/2014 15:45
URL:    Clicca qui

Maybe it doesn't chek the time on the server or uses a different time zone?

II. Steps to reproduce the Issue:
1. I created the event
2. the received email is 1 hour in the past tahen the event ...
3.

Original issue reported on code.google.com by myweb4pe...@gmail.com on 16 Jan 2014 at 3:24

[GoogleCodeExporter]

I noticed the reminder has the right time. The wrong time is only inside the 
mail sent after you save the event.

Original comment by myweb4pe...@gmail.com on 16 Jan 2014 at 3:47

[GoogleCodeExporter]

Ok, I did a check trying to set my timezone in the roundcube per user setting. 
Nothing changed.

Then I checked the  calendar.php file and I noticed this:

$val['start'] = gmdate('Y-m-d\TH:i:s.000+00:00',$val['start']);
and 
$val['end'] = gmdate('Y-m-d\TH:i:s.000+00:00',$val['end']);

I changed to 
$val['start'] = gmdate('Y-m-d\TH:i:s.000-01:00',$val['start']);
and
$val['end'] = gmdate('Y-m-d\TH:i:s.000-01:00',$val['end']);

and the time used is now correct.
Maybe it would be useful let the admin sets the timezone for the plugin. (i 
cannot find something like that in the config file)

Also, when I save the event, i get a mail from my own email account. The remind 
comes with the "noreply" account. I didn't checked if it's a global account or 
if everyone will get the noreply@domain... 
Why don't use the same method for saving the event?

Original comment by myweb4pe...@gmail.com on 16 Jan 2014 at 4:46

[GoogleCodeExporter]

Original comment by myroundc...@gmail.com on 17 Jan 2014 at 6:07

• Changed title: [calendar] - Event notifications (timezone offset)
• Changed state: Accepted

[GoogleCodeExporter]

This part of the code was very old. Older Roundcube versions didn't support 
timezone names. Time you saw in the notifications were GMT (no timezone 
offset). As Roundcube meanwhile has full timezone support, I have re-coded the 
section.

Regarding the sender: Notifications show as sender the user who 
created/modified or deleted the event. That's import for shared calendars.

Reminders show as sender the a service account. We don't have a logged in user 
when the reminders cron is running. To use the recipient as sender does not 
work for all. If the SMTP server is configured to allow as sender name only the 
account owner, then sending by using a different name would fail. So, I won't 
change this part.

Original comment by myroundc...@gmail.com on 17 Jan 2014 at 6:14

[GoogleCodeExporter]

Original comment by myroundc...@gmail.com on 17 Jan 2014 at 6:15

• Changed state: Done