raecosia / myroundcube

Automatically exported from code.google.com/p/myroundcube
0 stars 0 forks source link

[calendar]Cant edit/set complete task item. #730

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago
Hi there, please give a hand… 

The COMPLETE: Property for ICS when viewing CURL output is wrong / broken. 

So you could never click complete item on task list. The item would just return 
after synchronization as uncompleted on the tasks.

Below is working example ICAL on Iphone:
![CDATA[BEGIN:VCALENDAR
VERSION:2.0
CALSCALE:GREGORIAN
PRODID:-//Apple Inc.//iOS 7.1.2//EN
BEGIN:VTODO
UID:2B580C22-DF36-4FEC-946C-C62D0E0FE441
COMPLETED:20140914T194006Z
CREATED:20140914T193912Z
DTSTAMP:20140914T194009Z
LAST-MODIFIED:20140914T194008Z
PERCENT-COMPLETE:100
SEQUENCE:0
STATUS:COMPLETED
SUMMARY:Poef
X-APPLE-SORT-ORDER:432416352
END:VTODO
END:VCALENDAR

Below is broken version Roundcube trying to set item complete:
BEGIN:VCALENDAR
VERSION:2.0
PRODID:-//AITOnline Webmail//NONSGML Calendar//EN
BEGIN:VTIMEZONE
TZID:Africa/Johannesburg
BEGIN:STANDARD
DTSTART:19700101T020000Z
TZNAME:SAST
TZOFFSETFROM:+0200
TZOFFSETTO:+0200
END:STANDARD
END:VTIMEZONE
BEGIN:VTODO
PERCENT-COMPLETE:100
STATUS:COMPLETED
COMPLETED;TZID=Africa/Johannesburg:20140914T214603
DTSTAMP:20140914T194603Z
SEQUENCE:1410723963
SUMMARY:ok cool
UID:20140914T214041Z-w3CTRYP
END:VTODO
END:VCALENDAR

I tried to fix this myself, but I have not got enough knowledge of all the 
different code being used, and not sure how to correctly fix this. 

Please help? 

Token: dd2017391a3b60f68687c25c30eef0f1 (Don't modify this token!)
Version: 18.2.3 (20-08-2014)
PHP: 5.5.9-1ubuntu4.3
RCMAIL: 1.0.2
Database: mysql
SERVER: Apache/2.4.7 (Ubuntu)
----
I.  Issue Description:

II. Steps to reproduce the Issue:
1.
2.
3.

Original issue reported on code.google.com by christia...@gmail.com on 14 Sep 2014 at 8:54

GoogleCodeExporter commented 8 years ago
Please this is fairly urgent, we happy to make a contribution to getting it 
fixed properly. 

Original comment by christia...@gmail.com on 14 Sep 2014 at 9:17

GoogleCodeExporter commented 8 years ago
Information displaying the property is the problem. The difference is apple 
ICAL client does not add the strange ;Timezone info so it works. But it does 
not work from roundcube using caledner + calendar_plus plugin

[14-Sep-2014 23:19:07 +0200]: 
Method: PUT
[14-Sep-2014 23:19:07 +0200]: 
Request:
__________
https://dav.aitonline.co.za:443/calendars/users/chris@aitonline.co.za/calendar/2
0140914T214135Z-ZeNTwHq.ics

BEGIN:VCALENDAR
VERSION:2.0
PRODID:-//AITOnline Webmail//NONSGML Calendar//EN
BEGIN:VTIMEZONE
TZID:Africa/Johannesburg
BEGIN:STANDARD
DTSTART:19700101T020000Z
TZNAME:SAST
TZOFFSETFROM:+0200
TZOFFSETTO:+0200
END:STANDARD
END:VTIMEZONE
BEGIN:VTODO
PERCENT-COMPLETE:100
STATUS:COMPLETED
COMPLETED;TZID=Africa/Johannesburg:20140914T231906
DTSTAMP:20140914T211906Z
SEQUENCE:1410729546
SUMMARY:hhhh
UID:20140914T214135Z-ZeNTwHq
END:VTODO
END:VCALENDAR
[14-Sep-2014 23:19:07 +0200]: 
__________
Response:
__________
HTTP/1.1 401 Unauthorized
Date: Sun, 14 Sep 2014 21:19:21 GMT
Server: Twisted/13.2.0 TwistedWeb/9.0.0
WWW-Authenticate: digest nonce="f47b9bef30811ba5727030c0", algorithm="md5", 
opaque="e29d7dc3341d5cc05f805fad8c8c37f0-ZjQ3YjliZWYzMDgxMWJhNTcyNzAzMGMwLDo6ZmZ
mZjoxOTYuNDYuMTg2LjgsMTQxMDcyOTU2MQ==", realm="AITOnline"
Strict-Transport-Security: max-age=604800
DAV: 1, access-control, calendar-access, calendar-schedule, 
calendar-auto-schedule, calendar-availability, inbox-availability, 
calendar-proxy, calendarserver-private-events, calendarserver-private-comments, 
calendarserver-sharing, calendarserver-sharing-no-scheduling, 
calendar-query-extended, calendar-default-alarms, 
calendarserver-partstat-changes, calendar-no-timezone, 
calendarserver-recurrence-split, addressbook, extended-mkcol, 
calendarserver-principal-property-search, calendarserver-principal-search, 
calendarserver-home-sync
Content-Type: text/html;charset=utf-8
Content-Length: 141
Connection: close

HTTP/1.1 403 Forbidden
Content-Length: 323
Server: Twisted/13.2.0 TwistedWeb/9.0.0
DAV: 1, access-control, calendar-access, calendar-schedule, 
calendar-auto-schedule, calendar-availability, inbox-availability, 
calendar-proxy, calendarserver-private-events, calendarserver-private-comments, 
calendarserver-sharing, calendarserver-sharing-no-scheduling, 
calendar-query-extended, calendar-default-alarms, 
calendarserver-partstat-changes, calendar-no-timezone, 
calendarserver-recurrence-split, addressbook, extended-mkcol, 
calendarserver-principal-property-search, calendarserver-principal-search, 
calendarserver-home-sync
Content-Type: text/xml
Date: Sun, 14 Sep 2014 21:19:21 GMT
Strict-Transport-Security: max-age=604800
Connection: close

<?xml version='1.0' encoding='UTF-8'?>
<error xmlns='DAV:'>
  <valid-calendar-data xmlns='urn:ietf:params:xml:ns:caldav'/>
  <error-description xmlns='http://twistedmatrix.com/xml_namespace/dav/'><![CDATA[Calendar data had unfixable problems:
  [VTODO] Property value incorrect: COMPLETED]]></error-description>
</error>
^C
root@vinnig:/usr/share/roundcube/logs# 

Original comment by christia...@gmail.com on 14 Sep 2014 at 9:20

GoogleCodeExporter commented 8 years ago
COMPLETED is a DATE-TIME field. So, a timezone identifier paramater should be 
valid. Nevertheless I have released a workaround. Which CarDAV server are you 
using?

Original comment by myroundc...@gmail.com on 15 Sep 2014 at 4:16

GoogleCodeExporter commented 8 years ago
Hi there,

We using Apple Calendar Server. 

Original comment by christia...@gmail.com on 15 Sep 2014 at 7:41