search

raeedcho / temper

a wireless-only split keyboard based on the chocofi
CERN Open Hardware Licence Version 2 - Permissive
242 stars 12 forks source link

Building Miryoku does not work #17

Closed Zoltan-Balazs closed 4 months ago

Zoltan-Balazs commented 4 months ago

Whenever I try to build the Miryoku firmware, it does not work, see: https://github.com/Zoltan-Balazs/miryoku_zmk/actions/runs/8844616666

I see that the Temper was added like the Corne to the Miryoku repository; building that in the exact same way, just changing temper to corne in the shield section is successful: https://github.com/Zoltan-Balazs/miryoku_zmk/actions/runs/8844680219

calerouxz commented 4 months ago

Try building both sides on separate runs. If I remember correctly, building them together resulted in errors for me.

Zoltan-Balazs commented 4 months ago

Thank you, unfortunately the build still fails with Error: Keymap found but shield not found. Board used for shield. It seems like the workflow does not recognise temper_right or temper_left as valid shields

calerouxz commented 4 months ago

I'll try a build later today and report back.

calerouxz commented 4 months ago

This didn't build for me today either, it may be worth raising a discussion, as I can't see missing or otherwise missing information on the files.

calerouxz commented 4 months ago

Update on this matter! I found the issue and why the build for the temper was broken on Miryoku. I'll keep this documented here for posterity and I'll try posting a PR to Miryoku ZMK. The outboard refs for temper needed to be updated, as this commit moved the files on the temper's repository and Miryoku outboards require the refs to build. I've opened this PR to fix it in Miryoku ZMK.

raeedcho commented 4 months ago

Ah yes, I had to move the files to comply with the new Zephyr update but didn't realize it would break the Miryoku build. Thanks for looking into and fixing it!

calerouxz commented 4 months ago

The PR regarding the temper has been merged into Miryoku. I tested a build (and flashed) and it now works correctly. Manna also made a sample build which also compiled. @Zoltan-Balazs you can sync your fork and it should now work.

This issue could now be marked as closed.

Zoltan-Balazs commented 4 months ago

Thank you, it works as intended, I was able to verify on my own fork as well! I don't think I would've been able to figure this out, thank you @calerouxz :smile: