raelgc / scudcloud

ScudCloud - Slack for Linux
https://launchpad.net/~rael-gc/+archive/ubuntu/scudcloud
MIT License
1.22k stars 99 forks source link

Fixing encoded characters in http_proxy. #578

Closed nathanpw closed 7 years ago

nathanpw commented 7 years ago

Fixes https://github.com/raelgc/scudcloud/issues/577

raelgc commented 7 years ago

Thanks @nathanpw!

Just to double check: have you tested for (1) non encoded chars proxies and (2) with no proxy connections? To make sure we'll not broken for other users.

nathanpw commented 7 years ago

I checked with and without encoded urls, and both worked for me. I can't test without a proxy right now. I can try it later tonight.