raerose01 / deconstructSigs

deconstructSigs
138 stars 47 forks source link

Added stacked bar chart and smart db colouring #57

Closed sfacista closed 4 years ago

sfacista commented 4 years ago

Added stacked bar plot functionality. I was also having a lot of issues with figuring out how to implement the v3 db colouring scheme. It wasn't entirely implicit for the pie chart IMO. I built in an additional field to the which signatures object that keeps track of which db style was used. The pic/ stacked bar plotting now changes colour intelligently.

I have not done much testing with this, but it works great for my data. I am a big fan of stacked bar vice the pie chart. I added a legend. I tried to keep it minimalist. You might be able to clean up the code for the stacked bar. It was really just a lift of the pie chart code.

I haven't done sufficient testing, but I think the added functionality is worth a pull.

sfacista commented 4 years ago

Failed to get the full stack functional. There's something missing from the integration process. Will leave to be pushed.