Closed dale3h closed 4 years ago
@dale3h, nice job, this looks good. I'm not too worried about the line too long, and Github uses 127 characters for the length limit in the web based editor, which is a good baseline. I actually did add automated lint testing using flake8 to all checkins: https://github.com/raetha/wyzesense2mqtt/blob/master/.github/workflows/pythonapp.yaml
It would be good to check that it is configured well, as I did that before I really understood linting.
Otherwise I expect I'll merge this soon.
Thank you for pointing me in the right direction of the workflow file. I will use these as guidelines for running flake8 locally from now on!
I am not 100% familiar on how to setup checks on all PRs, but is this something that you might be able to do?
I think you might need to add Actions support to your fork of the repository, and then you'll see them on the commits. Since the file is already in place, it should just run. But I'm not sure how to display that in the PR itself, maybe that happens automatically if the associated commits were running it.
Under the Settings section is an Actions tab where you can enable them to run. Give that a try on your fork and see if they show up the next time you commit something.
Resolve all flake8 issues except for E501 and E722.
I am not 100% sure how to address the remaining rules, so I didn't touch them.