search

raethkcj / RatingBuster

An item comparison tool for WoW Classic.
GNU General Public License v2.0
58 stars 14 forks source link

Update frFR.lua #102

Closed Hantunaar closed 2 years ago

Hantunaar commented 2 years ago

updated with new entries from wotlk updates can't find the entry for the new "Show Attack power from Armor" for DKs, I guess the addon generates it automaticaly at some point from strings like "Show ATTACK_POWER_TOOLTIP from ARMOR", which remains understandable but could be reworded to follow the same pattern as all the others lines, if you're picky :p

raethkcj commented 2 years ago

Yeah, I kind of overhauled the way the settings menu works so that it is auto-generated from stat modifiers that each class has in each expansion. This probably doesn't play nice with most languages' grammar 🤔

Still, you are welcome to override some of the generated bits if you edit these strings (feel free to completely delete the GlobalString constants if they don't make sense): https://github.com/raethkcj/RatingBuster/blob/2ade24cca5a15539440caf8ef0bccc8ab5b184c5/locales/frFR.lua#L67-L89

If you were to edit those, how close would you be to your ideal translations? At the very least I should probably just add L["Show"] instead of using the SHOW GlobalString. I guess I keep flip flopping between a) trying to minimize the amount of localization required, and b) getting the most natural-sounding localization possible

Hantunaar commented 2 years ago

Right now it's shown as "Afficher Puissance d'attaque par Armure", where every other line only shows the stat and then there is an additional tooltip with a more precise phrase (see picture) I personally think the later to be a little bit more cleaner, and it allows to shorten stats names if needed, but it's understandable both ways ratingbuster

raethkcj commented 2 years ago

I see. I wouldn't mind changing it to the short name by default, with the longer description in tooltip, but if I change it I would like it to be consistent across all locales/stats. Currently most non-generated stats use the long description in other locales.