[Bug]: Multiple Russian locale bugs

[Mard35]

I tested my settings profile on the Russian and English game client and found a lot of bugs of Russian locale. It turned out that part of stat conversions in Russian localization never worked and does not work to this day. Here is a screenshot of the same item in English and Russian localization

1) Armor to AP conversion from Bladed Armor / Armored to the Teeth talents does not work and has never worked in Russian localization, although it works fine in English localization (screenshot above). Even after i provided declensions for armor, still doesn’t work for gear, but it works fine for armor consumables.

2) Armor penetration rating conversion doesn’t work in RU locale but it works fine in English localization (1st screenshot above). 3) Attack power is converted to x2 Attack power as strength. Attack power in russian is "Сила атаки" and strength is "Сила", but addon sees only word "Сила" in attack power and counts it as strength and converts to AP again.

4) Strength is converted to block chance for some reason, instead of block value. In Russian it should be just «Блок» I mean it’s converted correctly but using wrong stat name.

5) Not exactly a bug, but misleading: Defense breakdown to % x 5 is incorrect. Crit Avoidance should not be here because it’s not a real avoidance which is summed up with all the dodge, parry, block and miss. Little example: item has 49 defense rating, it’s a 0.4% dodge, 0.4% parry, 0.4% block, 0,4% miss which means 0.4 x 4 = 1.6% Total avoidance. Yes, it gives 0.4 % crit avoidance too, but Total is still 1.6% = 0.4 x 4. But your addon says it’s 0.40% x 5 which is incorrect. Nobody needs crit avoidance here, it's just confusing and misleading, please just remove crit avoidance from breakdown and let it be x4 instead of x5.

6) Final suggestion: look how compact English tooltip looks like with short stat and rating names. And how ugly Russian tooltip looks like because of too long rating names.

All these «к вер. крит. удара» and «к вер. уклонения» etc are toooo long and huge. You can easily shorten them. For example: instead of using «к вер. крит. удара» you can use «Крита» like you doing this in English. You can even use English words, we will undesrstand that. Every Russian knows English stat names, we are using english stat names in our speech and theorycrafting, we don’t even need stat translation from addon, only conversion is needed. You are free to not translate stat names in tooltips. Sorry for my bad English.

Addon Source

GitHub Releases

Version

1.6.3

Locale

Russian

Talent Specialization

Protection Warrior

Race

Undead

[Mard35]

In addition to bug № 2: Armor penetration rating contains the word «брони» and addon thinks it’s literally armor and converts it to AP bonus because of Armored to the Teeth talent for Fury warrior.

In addition to bug № 3: Attack power is also converted to block chance because of the word «силу»

Addon just goes crazy with the Russian language)

[Mard35]

Ok, i fixed bug № 2, 3, 4 by myself. It was pretty easy. It's so funny that you are violating your own addon rules in locale files. It says in comments: "longer strings should be listed first". But your AP and armor penetration rating were on the LAST places. So i moved them at first place and did some other renaming. Check the file i linked. I still failed to fix Armor to AP conversion from Bladed Armor / Armored to the Teeth talents on gear. There is something wrong with stat scanning in statlogic. Also i found a lot of missing translation and misunderstanding how the Russian language works in ruRU.lua files RatingBuster ruRU fixed.txt

[raethkcj]

You're welcome to open a pull request if you want to contribute. The translations that exist for Russian are generous contributions from users, as you saw in #9. Every language besides English requires 3rd-party translations to function. I maintain this addon for my own enjoyment in my own free time, I'm not here to waste time bickering with you.

If you have fixes for issues 1-4 then I will happily consider them in a pull request. 5 is working as intended and can be configured in the addon settings. For 6 I would accept shorter Russian strings if you feel you can make them more clear, but I won't be changing them to English.

[Mard35]

Ok, I am not a programmer, i created a pull request. Is it correct? I can't fix 1st bug with armor by myself. Could you briefly explain to me how statlogic works? 5th is working as intended, but it's not correctly intended (i explained above why). I want to remove crit avoidance from breakdown, but i still want to see other x4 avoidances. I can't configure it in options.

[raethkcj]

Thanks, I've merged your changes and fixed the missing Armor breakdown. The colon was causing the problem. I've put your request for Defense breakdown in a separate Feature Request.