search

raethkcj / RatingBuster

An item comparison tool for WoW Classic.
GNU General Public License v2.0
58 stars 14 forks source link

Sometimes Ranged AP don't get calculated in summary #32

Closed Citano closed 3 years ago

Citano commented 3 years ago

For some reason, Ranged AP does not always get calculated as shown in the example here. Not sure what triggers it nor how to reproduce. image

krydd commented 3 years ago

I have seen the same problem for some items as well: rap_missing

aeadio commented 3 years ago

Doesn't just happen for RAP. Happens for multiple stats, including melee AP. There seems to either be a delay in tooltip scanning logic, or it doesn't trigger sometimes. The actual calculation logic doesn't seem to be off, since it will eventually populate the values correctly if you keep trying, and/or reloading.

raethkcj commented 3 years ago

Item data aren't guaranteed to exist when you first set a tooltip to an item. RatingBuster caches the first result for performance whether it got any real data or not, so when the data comes in later, RatingBuster is stuck using its old empty cache version. For most of WoW there haven't been clean ways around this, but there are some new ItemMixin APIs since BFA that may help:

https://wowpedia.fandom.com/wiki/ItemMixin

It is odd that it's getting partial stats though, so it's possible there's actually just an issue with one or more of the StatLogic scanners.

chefBrian commented 3 years ago

Yeah this is also happening for mele ap. Agility isn't considered at all. Also cannot trigger AP conversion for AGI to be displayed either.

raethkcj commented 3 years ago

@chefBrian agi seems like a separate issue, what class and locale?

chefBrian commented 3 years ago

@raethkcj my fault - I will create a separate issue