raethkcj / RatingBuster

An item comparison tool for WoW Classic.
GNU General Public License v2.0
57 stars 14 forks source link

Offhand isn't calculating correctly. #35

Closed darkcloud784 closed 3 years ago

darkcloud784 commented 3 years ago

image

darkcloud784 commented 3 years ago

@raethkcj No update to this issue? Seems to still happen on 1.0.10.

raethkcj commented 3 years ago

All the patterns and calculations are correct, the game just doesn't consistently send data as soon as you mouseover an item.

darkcloud784 commented 3 years ago

All the patterns and calculations are correct, the game just doesn't consistently send data as soon as you mouseover an item.

Weird, is there a reason for this?

raethkcj commented 3 years ago

Yeah, for items that your client doesn't have cached, the server presumably needs to do a database lookup before responding with the info. The response is async so that neither your client nor the server gets locked. To players this normally looks close to instant but addons can see the empty data. Can probably be fixed for this addon in a couple different ways but I haven't had time to do so yet.

darkcloud784 commented 3 years ago

Yeah, for items that your client doesn't have cached, the server presumably needs to do a database lookup before responding with the info. The response is async so that neither your client nor the server gets locked. To players this normally looks close to instant but addons can see the empty data. Can probably be fixed for this addon in a couple different ways but I haven't had time to do so yet.

Thank you for the detailed response and explanation. Hopefully you can get some time to put in the fixes you mentioned.