raethkcj / RatingBuster

An item comparison tool for WoW Classic.
GNU General Public License v2.0
58 stars 14 forks source link

Item's stats shown in summary scale with percentage buffs currently on the player #81

Closed Lackadaisical18 closed 2 years ago

Lackadaisical18 commented 2 years ago

To reproduce:

My best guess is that this comes from accounting for the paladin Divine Strength talent (+10% str), as that bonus is properly reflected in the stat summary for all gear with strength when talented into it.

I did not test this with anything besides Kings but I presume any percentage buff or malus would have the same effect. I did test with non-paladin characters and got the same results. As expected, things like crit from rating and ap from flat ap do not scale this way. Screenshots available upon request, version is current with GitHub.

I suppose this could be intended, but a player who doesn't know about this interaction could be confused by the changing numbers on static items.

raethkcj commented 2 years ago

Hi, this is indeed an intended feature of the addon. It's especially helpful for things like Druid forms, where stats like agility have different multipliers and conversions in each form.

Lackadaisical18 commented 2 years ago

It could at least be a toggle, then. I just don't understand why it's built in because all it can ever do is cause confusion for non-druids.