raethkcj / RatingBuster

An item comparison tool for WoW Classic.
GNU General Public License v2.0
58 stars 14 forks source link

Wrath classic support #82

Closed soapnrope closed 2 years ago

soapnrope commented 2 years ago

Hi, any plans to update this for Wrath classic? At quick glance seems like wrath classic runs more closer to like on retail client side therefore lot of changes might be required.

Anyhow here are some errors you get on wrath classic beta right now:

Message: ...ns\RatingBuster\libs\StatLogic-1.0\StatLogic-1.0.lua:3876: attempt to perform arithmetic on field '?' (a nil value) Time: Sat Jul 23 15:10:04 2022 Count: 1 Stack: ...ns\RatingBuster\libs\StatLogic-1.0\StatLogic-1.0.lua:3876: attempt to perform arithmetic on field '?' (a nil value) [string "@Interface\AddOns\RatingBuster\libs\StatLogic-1.0\StatLogic-1.0.lua"]:3876: in function GetNormalManaRegenFromSpi' [string "@Interface\AddOns\RatingBuster\RatingBuster.lua"]:2087: in functionfunc' [string "@Interface\AddOns\RatingBuster\RatingBuster.lua"]:2914: in function StatSummary' [string "@Interface\AddOns\RatingBuster\RatingBuster.lua"]:1567: in functionhandler' [string "@Interface\AddOns\RatingBuster\libs\TipHooker-1.0\TipHooker-1.0.lua"]:156: in function <...ns\RatingBuster\libs\TipHooker-1.0\TipHooker-1.0.lua:150>

[string "@Interface\AddOns\Informant\Libs\LibExtraTip\LibExtraTip.lua"]:508: in function <...ce\AddOns\Informant\Libs\LibExtraTip\LibExtraTip.lua:502>

[string "@Interface\AddOns\Informant\Libs\LibExtraTip\LibExtraTip.lua"]:434: in function SetBagItem' [string "@Interface\AddOns\ArkInventory\Core\ArkInventory.lua"]:8157: in functionFrame_Item_OnEnter'

Locals: self =

{ GetRAPFromAgi = defined @Interface\AddOns\RatingBuster\libs\StatLogic-1.0\StatLogic-1.0.lua:3328 GetReductionFromArmor = defined @Interface\AddOns\RatingBuster\libs\StatLogic-1.0\StatLogic-1.0.lua:2857 GetClassIDFromName = defined @Interface\AddOns\RatingBuster\libs\StatLogic-1.0\StatLogic-1.0.lua:439 GetSum = defined @Interface\AddOns\RatingBuster\libs\StatLogic-1.0\StatLogic-1.0.lua:4177 argCheck = defined @Interface\AddOns\RatingBuster\libs\StatLogic-1.0\StatLogic-1.0.lua:75 GetRAPPerAgi = defined @Interface\AddOns\RatingBuster\libs\StatLogic-1.0\StatLogic-1.0.lua:3289 GetStatMod = defined @Interface\AddOns\RatingBuster\libs\StatLogic-1.0\StatLogic-1.0.lua:2832 GetRatingIDFromName = defined @Interface\AddOns\RatingBuster\libs\StatLogic-1.0\StatLogic-1.0.lua:538 tip = StatLogicTooltip { } ModEnchantGem = defined @Interface\AddOns\RatingBuster\libs\StatLogic-1.0\StatLogic-1.0.lua:3967 RemoveGem = defined @Interface\AddOns\RatingBuster\libs\StatLogic-1.0\StatLogic-1.0.lua:3949 GetBlockValueFromStr = defined @Interface\AddOns\RatingBuster\libs\StatLogic-1.0\StatLogic-1.0.lua:3146 GetStatNameFromID = defined @Interface\AddOns\RatingBuster\libs\StatLogic-1.0\StatLogic-1.0.lua:443 RemoveEnchantGem = defined @Interface\AddOns\RatingBuster\libs\StatLogic-1.0\StatLogic-1.0.lua:3958 RemoveEnchant = defined @Interface\AddOns\RatingBuster\libs\StatLogic-1.0\StatLogic-1.0.lua:3940 GetBlockValuePerStr = defined @Interface\AddOns\RatingBuster\libs\StatLogic-1.0\StatLogic-1.0.lua:3108 GetAPFromAgi = defined @Interface\AddOns\RatingBuster\libs\StatLogic-1.0\StatLogic-1.0.lua:3239 GetNormalManaRegenFromSpi = defined @Interface\AddOns\RatingBuster\libs\StatLogic-1.0\StatLogic-1.0.lua:3859 GetDiff = defined @Interface\AddOns\RatingBuster\libs\StatLogic-1.0\StatLogic-1.0.lua:4823 GetAPPerAgi = defined @Interface\AddOns\RatingBuster\libs\StatLogic-1.0\StatLogic-1.0.lua:3197 GetHealthRegenFromSpi = defined @Interface\AddOns\RatingBuster\libs\StatLogic-1.0\StatLogic-1.0.lua:3920 GetEffectFromRating = defined @Interface\AddOns\RatingBuster\libs\StatLogic-1.0\StatLogic-1.0.lua:2962 StatTable =
{ } PatternTest = defined @Interface\AddOns\RatingBuster\libs\StatLogic-1.0\StatLogic-1.0.lua:4939 Bench = defined @Interface\AddOns\RatingBuster\libs\StatLogic-1.0\StatLogic-1.0.lua:4919 GetDodgePerAgi = defined @In

raethkcj commented 2 years ago

Hi! I am working on wrath support. I do have beta but it will take some time. I want to make sure the addon remains compatible with TBC rather than just copying the 3.3.5 values over the top.

raethkcj commented 2 years ago

I've begun releasing alpha builds with Wrath support: https://github.com/raethkcj/RatingBuster/releases/

So I'm going to close this issue. In addition to the changelogs there I posted a list of Known Issues to be aware of if you're interested in using it before launch: https://github.com/raethkcj/RatingBuster/issues/85