raethkcj / RatingBuster

An item comparison tool for WoW Classic.
GNU General Public License v2.0
58 stars 14 forks source link

Enchants not included in stat summary #87

Closed raethkcj closed 2 years ago

raethkcj commented 2 years ago

From @kylosandrax

(moving to new issue since Known Issues were mostly intended for beta, would prefer to have new issues filed individually)

I have checked several items and I believe item enchants are also not being included in the calculation. Can this be added to the list of Known Issues?

image

Exported weights

( Pawn: v1: "Tank": ArmorPenetration=0.2, Stamina=1, DefenseRating=0.8, CritRating=0.2, Dps=10, Strength=0.33, ParryRating=0.58, ExpertiseRating=0.67, Agility=0.6, HitRating=0.67, HasteRating=0.2, Armor=0.05, MetaSocketEffect=24, DodgeRating=0.7, Ap=0.06 )

Manual Calculation image

Observing the same with the +10 stam enchants

In-Game image

Manual Calculation image

Exactly 10 points out of sync, assuming that the 0.6 is being rounded up

raethkcj commented 2 years ago

Hi, this is the intended default. You can change it in the settings:

image

The intention here is to clearly compare a piece of loot that just dropped, or an item from a vendor or auction house that you don't yet have. Those new items will not yet have an enchant on them, so they would always be missing a significant amount of stats compared to an enchanted item you're currently wearing.

raethkcj commented 2 years ago

Actually I guess I didn't read your issue closely. This addon is not Pawn, it has nothing to do with EP weights for different specs @kylosandrax