Closed YujiTFD closed 2 years ago
Hi, I added the RatingBuster ruRU file, which should translate the menu for you, but in order to get full tooltip support, we need a ruRU translation for StatLogic as well. I'll try to highlight which patterns need to be translated, but it's not a small project:
https://github.com/raethkcj/RatingBuster/blob/29b53ef345297a9a71ec8daad492ad0406a79cd3/libs/StatLogic-1.0/ruRU.lua#L50-L59 https://github.com/raethkcj/RatingBuster/blob/29b53ef345297a9a71ec8daad492ad0406a79cd3/libs/StatLogic-1.0/ruRU.lua#L73 https://github.com/raethkcj/RatingBuster/blob/29b53ef345297a9a71ec8daad492ad0406a79cd3/libs/StatLogic-1.0/ruRU.lua#L137-L170 https://github.com/raethkcj/RatingBuster/blob/29b53ef345297a9a71ec8daad492ad0406a79cd3/libs/StatLogic-1.0/ruRU.lua#L188 https://github.com/raethkcj/RatingBuster/blob/29b53ef345297a9a71ec8daad492ad0406a79cd3/libs/StatLogic-1.0/ruRU.lua#L197-L201 https://github.com/raethkcj/RatingBuster/blob/29b53ef345297a9a71ec8daad492ad0406a79cd3/libs/StatLogic-1.0/ruRU.lua#L208-L209 https://github.com/raethkcj/RatingBuster/blob/29b53ef345297a9a71ec8daad492ad0406a79cd3/libs/StatLogic-1.0/ruRU.lua#L215-L216 https://github.com/raethkcj/RatingBuster/blob/29b53ef345297a9a71ec8daad492ad0406a79cd3/libs/StatLogic-1.0/ruRU.lua#L226 https://github.com/raethkcj/RatingBuster/blob/29b53ef345297a9a71ec8daad492ad0406a79cd3/libs/StatLogic-1.0/ruRU.lua#L230-L237 https://github.com/raethkcj/RatingBuster/blob/29b53ef345297a9a71ec8daad492ad0406a79cd3/libs/StatLogic-1.0/ruRU.lua#L243-L470 https://github.com/raethkcj/RatingBuster/blob/29b53ef345297a9a71ec8daad492ad0406a79cd3/libs/StatLogic-1.0/ruRU.lua#L489-L543 https://github.com/raethkcj/RatingBuster/blob/29b53ef345297a9a71ec8daad492ad0406a79cd3/libs/StatLogic-1.0/ruRU.lua#L552-L554 https://github.com/raethkcj/RatingBuster/blob/29b53ef345297a9a71ec8daad492ad0406a79cd3/libs/StatLogic-1.0/ruRU.lua#L558-L560 https://github.com/raethkcj/RatingBuster/blob/29b53ef345297a9a71ec8daad492ad0406a79cd3/libs/StatLogic-1.0/ruRU.lua#L562-L564 https://github.com/raethkcj/RatingBuster/blob/29b53ef345297a9a71ec8daad492ad0406a79cd3/libs/StatLogic-1.0/ruRU.lua#L589-L593 https://github.com/raethkcj/RatingBuster/blob/29b53ef345297a9a71ec8daad492ad0406a79cd3/libs/StatLogic-1.0/ruRU.lua#L598-L613 https://github.com/raethkcj/RatingBuster/blob/29b53ef345297a9a71ec8daad492ad0406a79cd3/libs/StatLogic-1.0/ruRU.lua#L635-L637 https://github.com/raethkcj/RatingBuster/blob/29b53ef345297a9a71ec8daad492ad0406a79cd3/libs/StatLogic-1.0/ruRU.lua#L651-L656 https://github.com/raethkcj/RatingBuster/blob/29b53ef345297a9a71ec8daad492ad0406a79cd3/libs/StatLogic-1.0/ruRU.lua#L686-L690
Issue in ru locale: wrong spell hit detect. Spell hit detects now as melee hit.
Need to add
{pattern = "рейтинга меткости заклинаний", id = CR_HIT_SPELL},
to \locales\ruRU.lua file (~713 line)
Hello, Thank you for your prompt response, but I meant not actually a translation, but a stats breakdown: as you can see at the screenshot, there are settings for Strength translation into AP and BR, but no actual translation at the item tooltip.
Issue in ru locale: wrong spell hit detect. Spell hit detects now as melee hit. Need to add
{pattern = "рейтинга меткости заклинаний", id = CR_HIT_SPELL},
to \locales\ruRU.lua file (~713 line)
Added, will be in next release
Hello, Thank you for your prompt response, but I meant not actually a translation, but a stats breakdown: as you can see at the screenshot, there are settings for Strength translation into AP and BR, but no actual translation at the item tooltip.
Currently the string I have for Strength is Сила
, in your image it looks like К Сила
. It looks like this К
is before every stat, is that correct for all base stats in Russian? And is it uppercase or lowercase (К or к
)?
Hello, Thank you for your prompt response, but I meant not actually a translation, but a stats breakdown: as you can see at the screenshot, there are settings for Strength translation into AP and BR, but no actual translation at the item tooltip.
Currently the string I have for Strength is
Сила
, in your image it looks likeК Сила
. It looks like thisК
is before every stat, is that correct for all base stats in Russian? And is it uppercase or lowercase (К or к
)?
"к" (lowercase) means "adds to" here. Also despite "Strength" is "Сила", it is not "к сила", but it is "к силе" in stats, because of wierd russian case system. :) Other stats stings: "+X к ловкости" (Agility) "+X к интеллекту" (Intellect) "+X к духу" (Spirit) "+X к выносливости" (Stamina) "+X к силе" (Strength) You also can check it if you change language at wowhead page (top right corner). For all languages.
Alright, I've gone ahead and added the base stat patterns to the localization file and released it. However, as I said in my earlier comment (https://github.com/raethkcj/RatingBuster/issues/9#issuecomment-851055849), we need translations of many, many patterns for everything to work correctly.
I wish there was a better way to do this, and maybe there is, but I'm just porting the version of this addon that existed in 2008 at the end of TBC. And this version at least relies on these hardcoded translations.
Here is preliminary update till string #188. ruRU.zip I struggle to understand regexp meaning sometimes, like when does it happen and what does it trigger. Plus, attempts to squeeze russian wording into english regexps are driving me nuts despite me being native Russian speaker. I'll continue translation, just need to dive deeper into LUA, which I am very rusty with.
need add {pattern = "критический удар %(заклинания%)", id = CR_CRIT_SPELL}, {pattern = "меткость %(заклинания%)", id = CR_HIT_SPELL},
Done, thank you!
Here is preliminary update till string #188. ruRU.zip I struggle to understand regexp meaning sometimes, like when does it happen and what does it trigger. Plus, attempts to squeeze russian wording into english regexps are driving me nuts despite me being native Russian speaker. I'll continue translation, just need to dive deeper into LUA, which I am very rusty with.
Thank you so much, I added these translations!
Could you please give current strokes that need to be translated?
The most important strings for functionality are the ones in StatIDLookup:
Note that these don't necessarily have a 1-to-1 correspondence with the English strings, and some of them were only used in TBC but are not present in Wrath. So it's okay to start with only the most common format that each stat comes in.
To confirm exactly what value will be looked up in this table, you can type /sldebug
in game, and then mouseover an item:
In this case, the second bit I've underlined is what should be localized. ["повышает рейтинг критического удара"] = {"CRIT_RATING",},
should be added to StatIDLookup, in place of the English CRIT_RATING patterns:
Ultimately, all of the English patterns here should be removed; they're mostly there as an example that multiple patterns might exist for the same stat, since Blizzard is not always consistent. Some of the more unique ones have example items at the end, for example Cloak of Darkness is one of the only items in the game that specifically increases melee crit rating, so it has a unique pattern.
Ok. I tried and fixed most of errors, but my fix code doesn't look beautiful. I'm sorry ;)
I added comments to some strokes when I add a new line (for more variables of text) or when I'm not sure what item I should check. I didn't manage to fix an error with the gear set names (for example hunter's T3 set "Доспехи Расхитителя гробниц").
Also I can't find any way to fix Strength on items. For example agility in this Scroll of Agility works fine (it says (+20 RAP) - ranged attack power)
but at the same time strength doesn't work (it's enabled in settings)
And I found a little bug with Intellect description. RB stats info devides the word "Интеллект" (к интеллект <> у) and looks ugly.
I will continue improving translation but just wanted to fix the most common errors first
Thank you so much! I opened a pull request to merge your changes and address some of the issues you mentioned.
Also I can't find any way to fix Strength on items.
Fixed in 27362a324bc88752a2607a31fb7d9c20aab4811f
And I found a little bug with Intellect description. RB stats info devides the word "Интеллект" (к интеллект <> у) and looks ugly.
Fixed in 7a71f289f7dc28295b24dfde37162a3880c3b5a9
-- Need help! In russian it looks like this: "Урон: 123-321"
Fixed in 5a1bedfeae8d06b1028cdb96e1e173b1a8543d6e
If you have more changes coming I'll wait to merge it for now. I'll also look into how the Set Bonus (8/9)
lines are handled in enUS, you don't need to worry about that.
You can merge it. I'll just wait next version to continue. Still have a few more classes to level up and look for errors with their stats =)
I moved your comments to a new issue, since they're not directly related to Russian support 🙂
Speaking of improvements for russian client I would like to change some text descriptions/names of stats. They look really bad now and inconsistent. You don't really have such problems on english client =).
For example on the screenshot above you can see conversation for Intellect (+0.21% крит закл, +2.5 урона). It probably uses some translations for other strokes or something. Ideally it should be (+2.5 к силе заклинаний, +0.21% к вероятности крит. удара). First, the order in my opinion should be changed so you have 'base' stats first and 'calculated' stats second. In this case it was crit chance (calculated) first and damage second. I changed it in the second 'ideal' option. Second thing is mostly for a russian client. On 3.3.5 client crit looked like "+10 к рейтингу критического удара" (+10 Critical Strike Rating), but on retail it's "+10 к критическому удару". It doesn't mention word 'rating' but I believe it's rating in fact. The issue is that you can understand this retail version as '+10 of something which increases your crit damage'. Not a good thing from blizzard translators actually. So I propose to use more undestandable text for calculated crit chance: "+10% Critical Strike Chance" or "+10% к вероятности крит. удара" or "+10% к вер. крит. удара" (2nd option is very long but 3rd looks a little bit more weird =)).
These text descriptions stay the same no matter what number in front of them. So I could just write translations for all types of these stats for this exact place (additional text in the item stats). And if you will decide to change the order in Stat summary as I suggested it will use these new lines as well without changes (it will look correct on russian). For a simple stats (like crit rating to crit chance conversations) text isn't needed, so it's fine.
There is another translation task for options menu (not everything is translated or it uses 'strokes translation' or just looks ugly) but it's not very important right now =).
Same issue with Spirit as it was with Intellect - stats devide word Spirit ("к духу").
The translations for the settings menu are defined here: https://github.com/raethkcj/RatingBuster/blob/0586ad9b38ecd894b0ff5b0da5e88b386690243a/locales/ruRU.lua#L22-L574
And the translations for Stat Breakdowns are at the bottom of the same file, here: https://github.com/raethkcj/RatingBuster/blob/0586ad9b38ecd894b0ff5b0da5e88b386690243a/locales/ruRU.lua#L781-L809
How can I get rid of this type of errors? (it says "Восполняет 8 ед. здоровья каждые 5 секунд." ("Restores 8 health every 5 sec"))
It doesn't see the whole stroke as one.
Also wands seem to have another type of damage text. Format is: "123 - 321 ед. урона от светлой магии" which includes information about magic school. How to deal with this?
Can't find any example of how to 'split' text into 'readable' part and ignored one. For example meta-gem for casters gives 12 crit rating and 3% crit damage increase. I suppose we need to read only crit rating part but not crit damage increase. So it gives error right now (but converts first part with rating) Similar issue with Riding crops. First part where it says about 10% mount speed increase works fine but second part (which says that it doesn't work on chars higher that lvl 70) has to be ignored.
I fixed Spirit word division and will post a new code a little bit later when I will fix errors above. Also have looked at code that generates summary strokes and it seems to use various tags to build stat names. If you have plans to add left/right positioning feature could you please add a new tags so I could translate it as whole stat name? At least for left (new) orientation.
Right now it looks like this (current right positioning for numbers): Заклинания Урон 123 ("Spells Damage" - read it as separate words, not as one name)
Should be: Урон заклинаний 123 (or I prefer to use word 'power' instead of 'damage' because it means that - "Сила заклинаний")
It doesn't see the whole stroke as one.
There is many similar errors because they have "сек." in it. We have dot when the word "seconds" is shorten. How to escape it?
How can I get rid of this type of errors? [image] (it says "Восполняет 8 ед. здоровья каждые 5 секунд." ("Restores 8 health every 5 sec")) It doesn't see the whole stroke as one.
There is many similar errors because they have "сек." in it. We have dot when the word "seconds" is shorten. How to escape it?
I'm fairly sure this will be a PreScanPattern
but I'll check soon.
Also wands seem to have another type of damage text.
I can fix this, but can you give several examples of how it looks for other damage schools? E.g. nature, frost, fire? I checked Wowhead but it uses declension and doesn't include the words от
or магии
:
Can't find any example of how to 'split' text into 'readable' part and ignored one. For example meta-gem for casters gives 12 crit rating and 3% crit damage increase. I suppose we need to read only crit rating part but not crit damage increase. So it gives error right now (but converts first part with rating)
This is already done. See how S1-1: '+12 к рейтингу критического удара'
and S1-2: 'на 3% увеличенный критический урон'
are separate? Since на 3% увеличенный критический урон
is not a stat we care about, you can just add it at the bottom of StatIDLookup
as an Exclude pattern:
["на 3% увеличенный критический урон"] = false,
And do the same with the second half of riding crop, I believe.
Right now it looks like this (current right positioning for numbers): Заклинания Урон 123 ("Spells Damage" - read it as separate words, not as one name)
Should be: Урон заклинаний 123 (or I prefer to use word 'power' instead of 'damage' because it means that - "Сила заклинаний")
These patterns are defined here, and you are welcome to overwrite them so they make more sense. They use GlobalStrings by default so that you get some translation even if no one has done translation work yet 🙂 https://github.com/raethkcj/RatingBuster/blob/0586ad9b38ecd894b0ff5b0da5e88b386690243a/libs/StatLogic/locales/ruRU.lua#L529
I can fix this, but can you give several examples of how it looks for other damage schools?
This is how text on wands looks like in the game:
It's Shadow, Holy, Arcane and Fire damage respectively (didn't find Nature but should have the same pattern)
Aparentely Blizzard added original stat comparison to Wrath Classic client. Didn't see any news about it but it's in the game at the moment (I tested - turned off all addons and it's definetely game feature and not some addon). Maybe you'll want to implement RatingBuster into these strokes. Russian translation on this new (old) feature is kinda bad by the way. They didn't use perfect localization from 3.3.5 client and just machine-translated it...
I was working on localization for v1.5.7 when you uploaded v1.5.8. And I had to merge my RatingBuster/locales/ruRU.lua and StatLogic/locales/ruRU.lua with the new ones (there are only change for color picking I believe). But addon stopped working correct on my feral druid - it doesn't show summary (but shows conversion). And it works fine on my mage (shows both conversion and summary). Idk maybe it's because of new update?
Also hit/hit rating didn't work for me at all, noticed it a few days ago (I believe before addition of original stat-comparison feature). Hit conversion worked fine but it showed 0%/0 in the summary. And I found a little mistake in russian localization file: some variables were written with capitals when in other localizations (I compared with german one) they had small letters. This was the cause of non-translated things in the addon settings window. I fixed most of these letters and menu became translated. If I accidentely broke something by my translation (if it causes summary to not show on my druid) I could just use template file and carefully copy translations to a new file.
I'm not very familiar with GitHub pull requests system so I'll just post code here. I'm sorry if it's inconvenient
Thanks! I've added your translations in version 1.5.10.
I moved a couple of things around and I believe I spotted all the differences from when you had to merge your changes.
Thanks for pointing out that Blizzard added their own stat comparison; I've added an option to hide it that's enabled by default.
You were correct to fix those capitalizations; I'm not sure how they got out of sync but thanks for fixing them!
There were some places in StatLogic where you added {"MELEE_HIT_RATING", "RANGED_HIT_RATING", "SPELL_HIT_RATING",},
. For ratings that are generic like this, you can just use the style {"HIT_RATING"},
and it will choose the right ones to convert to per expansion (it's different in TBC and Wrath). Keep this in mind if you make changes to Crit or Haste.
Also just a minor note, when Exclude patterns are rare or only show up on one item, like on Corrupted Ashbringer, it can be okay to just leave them missing. Adding the pattern will just make RatingBuster process that items tooltip slightly faster, but will add a small amount of memory usage for everyone who does not have the item. Since you added it, I left it in, just something to keep in mind.
I'm not sure what caused your Summary to disappear; it's possible you were missing a bracket }
or comma ,
. If it's still broken, you're probably getting a lua error and I'll investigate further.
Hello, why armor is converted to x2 attack power in russian locale? The word "усиление" doesn't mean strength here.
Hi.
No unit conversion for ruRU TBC Classic. Would you kindly look into it? Thank you in advance.