raethkcj / RatingBuster

An item comparison tool for WoW Classic.
GNU General Public License v2.0
58 stars 14 forks source link

Intense frame lag when hovering over items with Stat Summary enabled #93

Closed WillowGryph closed 2 years ago

WillowGryph commented 2 years ago

If you hover over an item on your character sheet while the Stat Summary feature is enabled, your game freezes for half a second. Disabling the Stat Summary feature fixes this problem.

raethkcj commented 2 years ago

Could you share your locale, race, talents, and gear? There are a lot of variables that could affect this and it's definitely not a universal problem.

WillowGryph commented 2 years ago

https://user-images.githubusercontent.com/113316179/189762269-9d1bdf20-9525-4283-986f-7cb2e0bf15ed.mp4

Here's a quick video. All addons except RatingBuster were disabled. Locale is English.

raethkcj commented 2 years ago

I've pushed some performance changes in 1.5.6. Here are some examples of the reductions in CPU time I'm seeing. The -25% is likely just variance in testing, but BuildGemmedTooltip, GetStatMod, and RemoveEnchant are the functions I specifically targeted for improvement. image

raethkcj commented 2 years ago

Have you had any improvement with version 1.5.6 or later?

Also, I couldn't help but notice that your Strength is converting to AP at 1:2 even though you are talented into Endless Winter. Which makes me wonder; did you by chance install RatingBuster from CurseForge? If so, that is not the version of the addon that this repo is for.