raethkcj / RatingBuster

An item comparison tool for WoW Classic.
GNU General Public License v2.0
58 stars 14 forks source link

[Feature Request] Add alignment/ordering options for Stat Summary stat names and values #96

Open raethkcj opened 2 years ago

raethkcj commented 2 years ago

Originally posted by @thehallowedfire in https://github.com/raethkcj/RatingBuster/issues/9#issuecomment-1249449213

Not sure if I should open another issue. Will write here for now. Want to make addon a little bit more shiny and closer to the original game look.

This is a screenshot from the original 3.3.5a client. I don't know why we don't have the same stats difference information on WotLK Classic client but w/e. You can see how these stats are ordered: _number name_ofstat image

Also the color of stat name is white which makes it look like other stats of item (look at the item description above on the screenshot). Green/red color for numbers are perfect but this is when you compare item and you see a difference between two items. I'm not sure what color would be better for the case when you just see stat summary. Perhaps it should be white as well as on basic item stats. We have additional information such as converted from ratings crit chance/haste/etc. These numbers (not stat names) could have more contrast color. I personally changed color to cyan just to make it look different from original numbers. image (this is how it looks in game now for me)

image (this is how I would like it to look)

On the last screenshot you can see text:

29.5 Spell Power
0.21% Critical Strike Chance    ## It uses cyan color because this stat is calculated from other stats and it isn't actually 'present' on the item
1.01% Spell Haste    ## Same as with previous stat it uses cyan because it is calculated. Text is considerable, maybe it should be just 'Haste', not sure

And I moved item level text (on russian it's 'Уровень предмета: 123', on english it's 'Item Level 123') to its original position but not sure if it's possible for you to implement text this way. And it's white.


I'm not sure what color to use for 'calculated stats' when we compare items. Drew two options: image and image

I can't really choose the best and more suitable.

raethkcj commented 2 years ago

Adding color options for the stat names and values in the summary is pretty reasonable and straightforward.

Having a separate color for "calculated" stats is more complex than it may seem; for example, many items have Attack Power directly on them, but might also provide Attack Power from Agility, Intellect, Stamina, or Armor.

Allowing the user to choose left/right alignment for both names and values is in theory doable, but I'd have to think how I want the settings menu for it to look.

thehallowedfire commented 2 years ago

Having a separate color for "calculated" stats is more complex than it may seem; for example, many items have Attack Power directly on them, but might also provide Attack Power from Agility, Intellect, Stamina, or Armor.

Well you're right. So if we don't compare items the numbers probably should have just the same color (white or custom like cyan).

raethkcj commented 2 years ago

The options to change the color of text and numbers were added in 1.5.8 (they still need to be localized). Changing the left/right position will take more time. image

raethkcj commented 2 years ago

ItemLevel and ItemID aren't getting colored by this change, I'll add those.