[Bug]: Defense breakdown seems to be incorrect

[Vishiswaz]

Describe the bug

I think the addon is incorrect with regards to how much Dodge, Parry, Miss, and Block you get from Defense.

RatingBuster seems to think that the difference between Boots of the Righteous Path (23 defense rating) and Blue's Greaves of the Righteous Guardian (0 defense rating) is 0.39% in Dodge, Parry, and Miss, but when I actually equip the item, it changes each of these by 0.31%.

For the record:

• I tested this before gemming and Enchanting
• My total Defense (not rating) is 502 when Boots of the Righteous Path are equipped and 492 when Blue's Greaves are equipped.

Addon Source

GitHub Releases

Version

1.5.7

Locale

English

Talent Specialization

Protection Paladin

Race

Human

[raethkcj]

Hmm, is your character's base defense skill capped? i.e. with no gear on, do you have 350/350 Defense skill for level 70?

[Vishiswaz]

Yes.

[raethkcj]

Could you share your character sheet Defense tooltip with and without Blue's equipped? e.g.

[Vishiswaz]

without

[Vishiswaz]

With

[Vishiswaz]

Blue's doesn't give defense rating. Did you mean the other one?

[raethkcj]

I did mean the other one, sorry about that!

[Vishiswaz]

Well, since you already have the screenshot without, here's the one with the other boots equipped

[raethkcj]

Ok, I'm seeing a difference of 6.08 - 5.68 = 0.4 which should just be a rounding difference from 0.39, rather than the 0.31

[Vishiswaz]

So that's very interesting. On the Defense tooltip, it matches RatingBuster, roughly 0.39%

But in reality, when you look at Dodge/Parry/Block, it's different, like 0.31%

[Vishiswaz]

I currently have a dodge gem now in the boots so let's just look at Parry.

With Boots of the Righteous Path:

With Blue's:

You'll notice that Parry only changes by 0.31%, not 0.39% as you would think based on RatingBuster and the Defense tooltip. Dodge also did it by this amount before I put the dodge gem in.

Diminishing returns perhaps?

[raethkcj]

Could be. IIRC the Stat Breakdown for Defense doesn't take DR into effect because it could end up being 3 different percentages, but the Stat Summary does.

[Vishiswaz]

So, RatingBuster is also missing that DR evaluation, then. Without it, it becomes functionally useless, as I'd have to keep equipping/unequipping items to see the actual difference.

[raethkcj]

The Breakdown ignores DR to keep tooltips uncluttered; if you turn on the Stat Summary for Sum Parry Chance, you should get the amount after DR:

[Vishiswaz]

No, that's the problem, Parry chance (and dodge but again, I've gemmed it atm) is not showing the correct value.

[Vishiswaz]

There's a decent chance that Block chance, in addition to Dodge chance and Parry chance, is not taking DR into effect when it comes to Defense Rating. And I'm not sure if Hit Avoidance is supposed to have DR, but it currently doesn't.

And, since Avoidance% pulls from those values, it is also incorrect.

[Vishiswaz]

With Blue's

With the other ones

RatingBuster predictions:

[raethkcj]

Apologies, all the DR calculations were set up correctly but apparently an argument to enable them in the display was missed. Fixed in master and I'll push a release shortly. Thanks for your patience debugging it.

[Vishiswaz]

Excellent, happy to help!