search

raexera / yoru

A custom Linux environment built on AwesomeWM
GNU General Public License v3.0
3.48k stars 198 forks source link

fix: error of dock #40

Closed ArchFeh closed 2 years ago

ArchFeh commented 2 years ago

I saw there was an error for dock. So I fixed it.

awesome: Error during a protected call: /home/archfeh/.config/awesome/ui/dock/dock.lua:52: bad argument #2 to 'sub' (number has no integer representation)

paulhersch commented 2 years ago

Can you give an example for a color value which caused this error to occur in the conversion process? Also: which lua version is awesome compiled against for you?

IN % B should already be of type int, as the modulo function is only defined with integer operations. It could be possible that some floating point fuckery is happening somewhere, but that is a lua issue then (especially with there modulo implementation).

if that fixes it for you, i think we can merge it tho. Rxyhn what do you think?

ArchFeh commented 2 years ago

I run this dotfile in gentoo and arch. With arch I follow every step from wiki, and for gentoo I did some hacks(but just for lua, I didn't edit the source code of dotfiles). I checked it in arch, there is no such error. Under gentoo with lua 5.4.4, and this fixes it for me.

raexera commented 2 years ago

the dock works perfectly without any error in my machine, so i think the dock didn't need any fix on it, i'll close this PR's thanks