Closed chtnnh closed 2 years ago
Willing to take this up!!
I think that if we could bump both of the libraries to their latest versions, that'd be preferable. Id be verh happy if you could tackle it!
Dont hesitate on bringing the possible solutions here if you are in doubt!
Thanks
Em seg., 25 de out. de 2021 12:52, Chaitanya Mittal < @.***> escreveu:
Willing to take this up!!
— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/rafaeelaudibert/Encryptor/issues/33#issuecomment-950793097, or unsubscribe https://github.com/notifications/unsubscribe-auth/AHUYAKFA5MFMWID7HPEZ37LUIUZFZANCNFSM5GU6VWQA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
Well, I don't mind trying that. Although removing the version from sentry-sdk[flask] seemed to do the trick. Let me know if that is an acceptable solution haha
Also, would it be possible for you to add the label:hacktoberfest to this? would help a lot 🥺
We'll probably need sentry-sdk[flask]
for it to properly integrate with flask
, so I'd rather you not remove it.
We'll probably need
sentry-sdk[flask]
for it to properly integrate withflask
, so I'd rather you not remove it.
Oh, I didn't remove sentry-sdk[flask], I just removed the version number so it automatically picks up the latest one. The event is showing up in sentry so I am sure it is working as expected. Let me know if that is acceptable and I will file a PR asap
Oh, that makes sense! Of course, go ahead and open a PR :)
Closed by #35
When running
pip install -r requirements.txt
as instructed in theREADME.md
, the following error causes the execution to stop:As pip suggests, these can be fixed by either loosening the sentry sdk version requirements or removing the package versions altogether.