rafaeelaudibert / Encryptor

Several encryptors (cryptographic secure or not) available in a REST API fashion, using Flask
8 stars 12 forks source link

Update requirements.txt and add AES encryptor #37

Closed jcrowe6 closed 1 year ago

jcrowe6 commented 1 year ago

Flask init fails because Jinja2 removed escape method in newest version - this changes requirements.txt to require exactly Jinja2==2.10.1

Closes #16

ghost commented 1 year ago
👇 Click on the image for a new way to code review - Make big changes easier — review code in small groups of related files - Know where to start — see the whole change at a glance - Take a code tour — explore the change with an interactive tour - Make comments and review — all fully sync’ed with github [Try it now!](https://app.codesee.io/r/reviews?pr=37&src=https%3A%2F%2Fgithub.com%2Frafaeelaudibert%2FEncryptor)

Review these changes using an interactive CodeSee Map

Legend

CodeSee Map Legend

rafaeelaudibert commented 1 year ago

That's great, thanks for noticing it Jeremiah.

Do you mant me to merge it now, or would you like me to wait until October, so that you can take part on Hacktoberfest? :)

jcrowe6 commented 1 year ago

You can merge it now - I also want to implement one of the open issues so I'll save that one for Hacktoberfest :D

jcrowe6 commented 1 year ago

I just got around to reading about/registering for Hacktoberfest and I see your original meaning now 😅 thanks for waiting to merge. I'll still probably submit another merge req and have 2/4 to complete the challenge. Thanks for letting me know!

rafaeelaudibert commented 1 year ago

@jcrowe6 That's nice you see it now hahahah.

I'd love to merge this, but can you add some tests for it? It should be easy to add it just by looking at the other encryptors.

jcrowe6 commented 1 year ago

@rafaeelaudibert Sure! Just made two test files in last commit.

jcrowe6 commented 1 year ago

@rafaeelaudibert This PR hasn't appeared yet for me on Hacktoberfest's site - I think this PR may need the label "hacktoberfest-accepted" to do so. Would you mind adding that label?