search

rafael2k / darkice

DarkIce is a live audio streamer. It records audio from an audio interface (e.g. sound card), encodes it and sends it to a streaming server. This is the official development repository of Darkice.
http://www.darkice.org
198 stars 46 forks source link

recording lost/overwritten when reconnecting to stream #141

Open jelko opened 5 years ago

jelko commented 5 years ago

When we use Darkice to stream to Liquidsoap → Icecast2 and record to a localDumpFile we encounter the following issue: When Liquidsoap is restarted, Darkice successfully reconnects, but the dumpFile is overwritten and therefore the old recording is lost. We do use fileAddDate = yes. Nonetheless the file is written to the timestamped filename when Darkice was originally started, and not to the moment of reconnection, what could be the expected behaviour.

How to reproduce?

1) Stream and Dump to Liquidsoap 2) Restart or Reload Liquidsoap sudo service airtime-liquidsoap restart 3) Recorded file start from zero

Setup: Ubuntu 18.04 with Liquidsoap 1.1.1, Icecast 2.4.3 and Darkice 1.3

neingeist commented 1 year ago

This is a ten year old bug, I think. I fixed it here:

darkice-proposed-fileAddDate-SIGUSR1-change-20120824.patch.txt

I've been using the attached patch on Darkice 1.1 for years. It just came up with the handover of an old project of mine. The patch may need work for Darkice 1.3.

To reproduce one can use fileAddDate and killall -USR1 darkice - darkice 1.1 just overwrote the old file. Same thing happens when reconnecting.

Perhaps someone using Darkice 1.3 can update/review the patch and submit a PR.

bjacke commented 1 year ago

This patch works fine for me, thank you, neingeist!

Is there anything to help to get this upstream?

bjacke commented 1 year ago

ping. Looking at this and other reported issues without feedback, I'm wondering if darkice is still actively maintained (?)