search

rafaelcaricio / gradient-parser

Parse CSS3 gradient definitions and build an AST object.
MIT License
62 stars 10 forks source link

Fails when radial-gradient shape is omitted but a size is provided #4

Closed gilmoreorless closed 8 years ago

gilmoreorless commented 9 years ago

The radial-gradient spec says that both shape and size are optional.

Gradient Parser works with most cases, but it fails in the specific case when a size is given (such as "furthest-corner") but a shape is omitted.

Example: https://jsbin.com/gogelo/5/edit?html,js,console

rafaelcaricio commented 8 years ago

Thank you for pointing this out and sorry for the very late fix.

pixelspark commented 3 years ago

@rafaelcaricio it looks like the built version was not updated: the error still exists in https://github.com/rafaelcaricio/gradient-parser/blob/master/build/node.js#L267. Would you mind updating the build as well?

rafaelcaricio commented 3 years ago

I will have a look. I did something wrong.. 🤦🏽