Stringify visit access a variable that does not exist

[jcharry]

    'visit': function(element) {
      if (!element) {
        return '';
      }

      if (element instanceof Array) {
        return visitor.visit_array(element, result);
      } else if (element.type) {
        var nodeVisitor = visitor['visit_' + element.type];
        if (nodeVisitor) {
          return nodeVisitor(element);
        } else {
          throw Error('Missing visitor visit_' + element.type);
        }
      } else {
        throw Error('Invalid node.');
      }
    }

in the call to visitor.visit_array, result is not defined, throwing an error.

[oceangravity]

Hi @jcharry I just published a npm package to parse CSS gradients https://npmjs.com/package/webskit-gradient-parser please let me know if is helpful for you, thank you!

javascript #css #gradients #npm #webskit

[strarsis]

@oceangravity: Nice! But the stringify feature is missing, which is very important for manipulating a gradient via its AST.

[strarsis]

@rafaelcaricio: Any chances this could be addressed in the near future? Currently stringifying is not possible. There is a fork with a fix for the issue: https://github.com/pixelspark/gradient-parser

[rafaelcaricio]

@strarsis this should be fixed now in version 1.0.2. Could you check if that works now?