rafaelgomesxyz / esgst

An extension that enhances SteamGifts / SteamTrades.
MIT License
147 stars 23 forks source link

Whitelist manager list is suddenly empty #1084

Closed Tristar7 closed 5 years ago

Tristar7 commented 5 years ago

Don't know what happened but suddenly it does not list any whitelist entries anymore. following error shows up in console:


 Uncaught TypeError: t.onClick is not a function
    at HTMLDivElement.onclick (esgst.js:1)
onclick @ esgst.js:1
esgst.js:1 Uncaught (in promise) TypeError: Cannot read property 'id' of undefined
    at t.<anonymous> (esgst.js:1)
    at w (esgst.js:54)
    at Generator._invoke (esgst.js:54)
    at Generator.e.(anonymous function) [as next] (chrome-extension://fekmnijijhcjkhoknkombinhhdnibdjn/esgst.js:54:15035)
    at n (esgst.js:1)
    at r (esgst.js:1)
(anonymous) @ esgst.js:1
w @ esgst.js:54
(anonymous) @ esgst.js:54
e.(anonymous function) @ esgst.js:54
n @ esgst.js:1
r @ esgst.js:1
Promise.then (async)
n @ esgst.js:1
r @ esgst.js:1
(anonymous) @ esgst.js:1
(anonymous) @ esgst.js:1
(anonymous) @ esgst.js:1
(anonymous) @ esgst.js:1
value @ esgst.js:1
(anonymous) @ esgst.js:1

The data seems to still to be there as it shows the signs besides names on other pages

rafaelgomesxyz commented 5 years ago

Please specify what you mean by "whitelist manager".

Tristar7 commented 5 years ago

Settings > "Manage Whitelist/Blacklist Checker caches:" button

rafaelgomesxyz commented 5 years ago

Thanks, there's a feature literally called Whitelist/Blacklist Manager, so I got confused. xD

rafaelgomesxyz commented 5 years ago

I've fixed the t.onClick console error, but I don't think it's related, because I get it and the list shows up fine for me.

I think the relevant error is Cannot read property 'id' of undefined, but I don't know yet where it's coming from.

Tristar7 commented 5 years ago

Those logs referring only to line 1 aren't really helping XD

I noticed the blacklist counter to drop that day, maybe someone deleted his account which tripped some checking function somewhere. Could also possibly be some unrelated data corruption but not sure how to investigate that.

I tried loading a one week old backup but that did not help.

rafaelgomesxyz commented 5 years ago

Yeah, that's Babel, it minifies the entire code for the user. You can get better logs if you test with the dev version, because dev versions aren't compiled with Babel.

Tristar7 commented 5 years ago

Uncaught (in promise) TypeError: Cannot read property 'id' of undefined at UsersWhitelistBlacklistChecker.wbc_setCheck (esgst.js:110939)

id: SavedUsers.users[SavedUsers.steamIds[WBC.Users[I]]].id

rafaelgomesxyz commented 5 years ago

I added a check to v8.1.6 (Dev.29) that allows you to bypass the bug, but if you want to actually fix it, I also added some logs to that version that output the username of the user followed by their Steam ID.

So you can install that version and see what the last log is, and then manually see what's the username of that user by going to https://www.steamgifts.com/go/user/XXXXXXXXXXXXXXXXX.

Tristar7 commented 5 years ago

I have run a WL check (which I have avoided out of data loss fear) on the previous version. That made the list reappear, but the exception still happens. I have now upgraded and got the causing user with the log. Doing a recheck even with clearing cache does not resolve that error. Don't know what's so special about this one

undefined 76561198036886086 https://www.steamgifts.com/go/user/76561198036886086 https://www.steamgifts.com/user/PraiseRhllor

rafaelgomesxyz commented 5 years ago

The problem appears to be that the username for that user is stored as "undefined". Perhaps they were added to the database through SteamTrades and then were not properly updated when used on SteamGifts? Do you use SteamTrades?

Tristar7 commented 5 years ago

I'm not visiting steamtrades with the Script on all too much but it can possibly have happened. Is there anyway for me to reset the data for this specific user?

rafaelgomesxyz commented 5 years ago

What did you mean when you said that the list reappeared but the exception still happened? The error should be gone, is it not?

rafaelgomesxyz commented 5 years ago

The user might be wrong, I've added a new log to the latest dev version that should output the correct user. Can you test it?

rafaelgomesxyz commented 5 years ago

Closing due to inactivity. If this is still happening, please let me know.