search

rafaelgomesxyz / esgst

An extension that enhances SteamGifts / SteamTrades.
MIT License
147 stars 23 forks source link

Activating 'Add button to specify parameters.' (2.17.1) breaks extension #1304

Closed Eiion closed 5 years ago

Eiion commented 5 years ago

Description ESGST feature stops ESGST from working

Steps to Reproduce

  1. Go to Settings of Giveaway Extractor
  2. Click on switch to turn on "Add button to specify parameters"
  3. Reload page
  4. ESGST and none of its menus/buttons show up anymore on Steamgifts

Console Errors none

System (please complete the following information):

Additional Context I've noticed that when using the extractor (e.g. on the current community train) at first everything looks like it used to: Download But once the extractor finishes loading all giveaways in additional settings show up: Download (1) So I tried the "Only extract from the current giveaway onward" - but when reloading/letting the extractor run again, it still loaded all previous giveaways in and also, after finishing, the switch was again turned to 'off'. I went on checking ESGST's settings to see if there's something in there and found 2.17.1 ("Add button to specify parameters"). Assuming that this was what I was looking for (the three additional options) I activated the feature but ESGST didn't even show up anymore on the page (while the extension was still displayed as running on the extensions page of Chrome). Closing and re-opening Chrome didn't help.

EDIT: After un-installing ESGST and re-installing it again from the Chrome Web Store and restoring the backup, things are running as intended - for now.

Eiion commented 5 years ago

I've tried recreating the issue but without success. Close this or leave it open if you feel like investigating. That certainly was odd.

rafaelgomesxyz commented 5 years ago

Do you know how to open the background page of an extension on Chrome? If this happens again, you could take a look at the console from the background page, as it might contain an error that prevented ESGST from being injected.

Eiion commented 5 years ago

No, I don't know how to do that.

Eiion commented 5 years ago

It's not related to the issue itself but apparently playing around with the filters yesterday cause the extension to not work again. As before ESGST is running but doesn't show up (none of the menus/features... nothing) on SG - which is why I'm adding it in here.

rafaelgomesxyz commented 5 years ago

Go to your extensions page (chrome://extensions/) and enable developer mode, there should be a link "background page" on ESGST. Click it and see if there are errors there. If there aren't, try disabling the extension, restarting the browser, opening the background page and re-enabling it.

Eiion commented 5 years ago

This is what I'm getting when on SG, after reloading the page: 6xbrowser-polyfill.js:1 Failed to send onMessage rejected reply TypeError: Message length exceeded maximum allowed length. at F.G.then.I (browser-polyfill.js:1) (anonymous) @ browser-polyfill.js:1 browser-polyfill.js:1 Failed to send onMessage rejected reply TypeError: Message length exceeded maximum allowed length. at F.G.then.I (browser-polyfill.js:1)

rafaelgomesxyz commented 5 years ago

What size is your storage?

Eiion commented 5 years ago

My RAM? 32 GB.

rafaelgomesxyz commented 5 years ago

No, your ESGST storage.

rafaelgomesxyz commented 5 years ago

I believe you can see it here: C:\Users\%username%\AppData\Local\Google\Chrome\User Data\Default\Local Extension Settings\ibedmjbicclcdfmghnkfldnplocgihna

Eiion commented 5 years ago

According to the extension page it's 2,2 MB. In the path mentioned above it's 13 files adding up to 45,3 MB. Screenshot

rafaelgomesxyz commented 5 years ago

You should be able to get the extension to run again by uninstalling, re-installing and restoring.

But yeah, it appears that your data is being corrupted somehow and going from 2 MB to 8 MB. If it's not too much trouble for you, you could analyze the ldb files (there's software for this) to see how exactly it got corrupted.

I'll take a look in the code to see if there's anything in the filters that could cause this.

Eiion commented 5 years ago

Sure, uninstalling, re-installing and restoring fixed it last time, too.

Let me know how to analyse them and I'll see when I get to it.

EDIT: Oh well, although I made a backup of the files before uninstalling the extensions, that backup got lost for some reason as well. Nevertheless, if it happens again, it would be good to know how to move on analyzing the files.

rafaelgomesxyz commented 5 years ago

I thought it was saved in a different format (on Firefox, it is). I can't seem to find a software that can open it. I mean, it can be opened with Notepad, but not sure if you'd be able to make out most of it.

Eiion commented 5 years ago

I could also look with Sublim Text - though I doubt either is much different as for just "looking". I could see if big chunks repeat. Other than that, I wouldn't know what to do with it.

rafaelgomesxyz commented 5 years ago

Yeah, seeing if big chunks repeat is a good idea, because something could be causing the storage to duplicate some parts.

Eiion commented 5 years ago

Ok, so if it ever happens again, this is what I'm going to do first.

rafaelgomesxyz commented 5 years ago

Closing because #1366 is most likely the same issue.