search

rafaelgomesxyz / esgst

An extension that enhances SteamGifts / SteamTrades.
MIT License
147 stars 23 forks source link

Internal: fix bug that does not delete old username key, preventing some features from working correctly #1319

Closed grez1 closed 5 years ago

grez1 commented 5 years ago

Description The group page loads, you see the status bar at the top count down that it's loading group status, but none are displayed.

Steps to Reproduce Go to group stats page...it's blank

Expected Behavior stats should load :D

Console Errors 00d6882754a5ab2e1ab54b384a54ac1b40a06baa_medium.jpg:1 Failed to load resource: the server responded with a status of 404 ()

Screenshots image

System (please complete the following information):

Additional Context Add any other context about the problem here.

rafaelgomesxyz commented 5 years ago

I cannot reproduce. Can you share your settings? Did this start happening on v8.3.7?

SquishedPotatoe commented 5 years ago

I can reproduce and still present in 8.3.8 and current chrome Version 74.0.3729.131 (Official Build) (64-bit) settings https://pastebin.com/ai7UMMBT

grez1 commented 5 years ago

Sorry that I missed your earlier message. I tried again the morning, and was still able to reproduce the issue. However, I got the ESGST update this afternoon, and now my stats are working again!

[cid:de83683c-d879-4ace-9ba9-f737707214fb]

From: SquishedPotatoe notifications@github.com Sent: Sunday, May 12, 2019 5:10 PM To: gsrafael01/ESGST Cc: grez1; Author Subject: Re: [gsrafael01/ESGST] Group stats are not displayed (#1319)

I can reproduce and still present in 8.3.8 and current chrome Version 74.0.3729.131 (Official Build) (64-bit) settings https://pastebin.com/ai7UMMBThttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fpastebin.com%2Fai7UMMBT&data=02%7C01%7C%7C648f422740cd43a8ab2608d6d726b129%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636932958505581143&sdata=iKd67Bfrdqa3Y4UKFtaOaGxwMUs%2FzgYDoqaxv32YUVI%3D&reserved=0

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHubhttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fgsrafael01%2FESGST%2Fissues%2F1319%23issuecomment-491633573&data=02%7C01%7C%7C648f422740cd43a8ab2608d6d726b129%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636932958505591154&sdata=HdRekOSIhndNUDsV7vj1nc3BZTnxkUjzAF%2BEmkuTkO8%3D&reserved=0, or mute the threadhttps://eur02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAE4YBVI4WIDMINV2QJXQMJTPVCIWTANCNFSM4HLLK5KQ&data=02%7C01%7C%7C648f422740cd43a8ab2608d6d726b129%7C84df9e7fe9f640afb435aaaaaaaaaaaa%7C1%7C0%7C636932958505601159&sdata=ZmzsHQbJJyWcQ6AHde3LqBqSKHgcqwBeap%2Bt7OQyUbE%3D&reserved=0.

rafaelgomesxyz commented 5 years ago

@SquishedPotatoe Can you confirm that it's working again?

SquishedPotatoe commented 5 years ago

Negative still broken in 8.3.13-dev.20

for me it breaks at if (!context || context.querySelector(`.table__column__heading`).textContent !== _class_Globals__WEBPACK_IMPORTED_MODULE_5__["gSettings"].username) { return; }

i can get stats if i just do context.querySelector(`.table__column__heading`).textContent;

rafaelgomesxyz commented 5 years ago

@SquishedPotatoe Can you see what value is in username or username_sg in your settings JSON?

SquishedPotatoe commented 5 years ago

@gsrafael01 "username":"","username_sg":"SquishedPotatoe"

rafaelgomesxyz commented 5 years ago

@SquishedPotatoe That's most likely the issue, username is replacing username_sg. Weird that username still exists for you, because I added a check to delete it in recent versions.

rafaelgomesxyz commented 5 years ago

@SquishedPotatoe Can you try backing up your JSON in the latest version and seeing if "username" still exists?

SquishedPotatoe commented 5 years ago

@gsrafael01 username still exits after backup

rafaelgomesxyz commented 5 years ago

@SquishedPotatoe How... The only thing I can think of is your settings not being saved after being fixed, because this line should be removing that property: https://github.com/gsrafael01/ESGST/blob/master/src/main.js#L276 Can you try loading a single SteamGifts tab? Maybe another tab is overwriting the current one.

rafaelgomesxyz commented 5 years ago

@SquishedPotatoe Oh. OH. I must be slow today. Of course that line isn't effective, because username is empty. facepalm

rafaelgomesxyz commented 5 years ago

https://github.com/gsrafael01/ESGST/commit/93e42fa587894565aa9d1e874131480a7d785c64

SquishedPotatoe commented 5 years ago

@gsrafael01 works now that you had your coffee ;)