Bookmarking Giveaways - heavy CPU load/takes long time

[Eiion]

Description Bookmarking a giveaway takes not only a very long time (about 9.5 seconds) but also causes heavy CPU load.

Steps to Reproduce

1. Go to random giveaway
2. Click on "Bookmark giveaway"
3. See error

Expected Behavior

1. Doesn't produce heavy CPU load
2. is done somewhat instant (1-2 seconds)

Console Errors none

Screenshots

System (please complete the following information):

• ESGST Version: 8.3.17
• Browser + Version: Chrome v75.0.3770.100

[rafaelgomesxyz]

I cannot reproduce, could be related to your storage size. Can you try loading the extension in another browser (clean data) and seeing if you can bookmark with no issues?

[Eiion]

I can't load it into another browser.

[rafaelgomesxyz]

Is it still happening? Does it happen for all giveaways?

[Eiion]

Yes, the browser freezes twice for a few seconds but CPU load only goes up to about 40+% instead of the 80+%. It happened with whatever giveaway and it still happens with no matter what giveaway.

[rafaelgomesxyz]

How big is your storage? If you want, you can share your settings with me so I can try to reproduce it, it might be a conflict with another feature.

[Eiion]

obsolete info Chrome cache cannot be changed via standard settings. (If I'm not mistaken it's set to 2GB-1 Byte by default.)

[rafaelgomesxyz]

I meant your ESGST storage size.

[Eiion]

The whole extension folder is just 2,30 MB (2.416.139 Bytes) big (unlike last time when my extension broke and just the one file was over 8MB big). computed_hashes 28KB verified_contents 3KB browser-polyfill 10KB esgst 2135KB esgst_sgtools 11KB eventPage 165KB icon 1KB manifest 2KB permissions.html 1KB permissions.js 8KB

[rafaelgomesxyz]

Well, in that case, are you able to share your settings?

[Eiion]

Here's the settings - it expires in a week: https://pastebin.com/W3pDauYs

[rafaelgomesxyz]

Is this still an issue? If so, are you interested in testing a method that could speed it up (you'll have to load a version of the extension manually through the developer mode)?

[Eiion]

I don't know, I have stopped bookmarking giveaways since then (because it was a problem).

[rafaelgomesxyz]

Well, can you try bookmarking a giveaway and seeing what happens?

[Eiion]

So, I just did. And it still is an issue very much:

On the graph you can see me bookmarking 4 giveaways - within 60 seconds. Making one bookmark takes about 11 seconds.

And this is un-bookmarking them again, one after another:

This is what un-bookmarking them at once looks like - clicked one after another within about 4 seconds:

[rafaelgomesxyz]

When v8.8.0 arrives in the store, if you're willing to test the new option to use a temporary storage (#1596), that might fix this problem.

[rafaelgomesxyz]

Any news here?

[Eiion]

I'm on a new system now and while CPU load naturally went down according to the more powerful CPU, it's still only a few seconds faster (9s instead of the 11s before) as you can see in the screenshot:

And once again, this is what un-bookmarking them at once looks like - clicked one after another within about 4 seconds:

[rafaelgomesxyz]

This was with temporary storage enabled?

[Eiion]

Back then not - for neither of these tests.

If you remember from another report (https://github.com/rafaelgomesxyz/esgst/issues/1676), I have given the temporary storage feature a try and ended up having to uninstall the extension and reinstall it as it completely broke ESGST for me.