search

rafaelgomesxyz / esgst

An extension that enhances SteamGifts / SteamTrades.
MIT License
147 stars 23 forks source link

Giveaway Info (7.2.14) - no rules available anymore #1508

Closed Eiion closed 4 years ago

Eiion commented 5 years ago

Description For Giveaway Info there are no rules anymore available with the recent version of ESGST - when activated it shows up on all SG pages.

Steps to Reproduce

  1. Go to settings of 7.2.14 and activate it
  2. Surf to any giveaway listing page
  3. See error

Expected Behavior There's an option to set up rules on which page a feature would or would not show up.

Console Errors none

System (please complete the following information):

rafaelgomesxyz commented 5 years ago

No error, see #1497.

Where do you not want it to run, I'll add the options based on demand.

Eiion commented 5 years ago

I didn't realize you removed paths for all features.

Using endless scrolling exclusively on all of SG the paths were quite a welcome feature as with all the information getting that information in the first place slows down things A LOT. So previously being able to select which information should be shown on which page really helps with getting things up in speed, not having to wait for an information getting loaded in on e.g. 20+ pages at once.

For example I had turned almost all information of on All as that's the page I am using to bank in points from the last page forward. On Wishlist I allowed more information but still dropped some, as I e.g. don't care about the chance of winning for games I have wishlisted. Opposite to that Chance of winning is interesting on Entered. And Giveaway Info I only need on my profile page, Created and New Giveaway. This feature especially slows things down massively on pages which is why I didn't use it where it's not helpful for me.

In summary, using endless scrolling paths allowed me to adjust information to being actually of interest to me while sacrificing not too much speed. Having everything on always everywhere definitely has an impact on usability.

Actually, ever since caching data slowed down so much (while steam web integration still gets data almost in an instant) I wanted to suggest a setting selector for quick switching between setting profiles. That way we could use a set of settings when more information is required and - with the flip of a switch - change to a more light weight set of settings for more sped up usage. Maybe with paths gone such a switch would be an alternative to bypass having paths by simply having the ability to use different sets of settings all together. But then something like "copy settings to other profile" should also be a thing for conveniently creating new setting profiles that use the same main features just to add or remove some other features.

(Talking of steam web integration being as fast as ever, I think there should be a user setting allowing us to adjust after how many milliseconds we want to pull data sets for games from steam instead of having something fixed like one set every 500ms or so. Sure, users might ran into the old block that makes you wait for half an hour until you can access the store again, but SWI doesn't trigger that block anymore either and users should simply be able to decide themselves if they prefer getting data as quick as possible or more quickly than currently while risking the 30 min block or if they rather take things slow to always be able to view the steam store. I'd certainly go for speed for much better i.e. fluid usability of SG+ESGST when I visit the site as I don't visit the steam store much anyways.)

rafaelgomesxyz commented 5 years ago

Game information is supposed to be retrieved from the server, rafaelgssa.com, not Steam. Is it not doing that for you? Do you have permissions for rafaelgssa.com set? I don't understand why it's so slow for you, retrieving things from the server should be much faster, since everything is cached and every user retrieves from there, preventing massive requests to Steam for the same thing.

Eiion commented 5 years ago

I've just taken another look and it seemed that now Game information is there in an instant. I guess this is a new feature, getting the data from your server? Just wondering because it used to takes quite a while for the data to show up - which is why I didn't have it on for all pages. But the second reason was to also keep the info per game clutter as low as possible to not fill up the page with too much un-needed information).

I don't know which detail in specific takes so long to get retrieved. I've talked about that before, that count down and spinning circle in different colours... only when all of them per page are done spinning all the search filters get applied - which can take really long. I would have to go one by one setting to find out which it is while could take quite a long time - which I don't have. Just taking a guess I'd say it's Trading Cards as that's the last info showing up typically? But as said, that's just a guess and I could be completely wrong.

rafaelgomesxyz commented 5 years ago

It's been retrieving info from my server since the beginning of the year though.

For categories that take longer, that info is available in their description in the settings menu, so you don't need to find them manually. Trading cards is the fastest, because it's available in the Steam API. It goes like this:

rafaelgomesxyz commented 4 years ago

Paths will be back in the next version (#1518).

Eiion commented 4 years ago

Nice!