rafaelgomesxyz / esgst

An extension that enhances SteamGifts / SteamTrades.
MIT License
147 stars 23 forks source link

New div (SG ad?) element midpage #1588

Closed marlop352 closed 4 years ago

marlop352 commented 4 years ago

Description A new element was added today on the middle of the page on every page of the main giveaway list, it breaks the flow on gridview.

Steps to Reproduce

  1. Go to the main page
  2. Find the 25th giveaway on it
  3. there will be a space or ad (it doesn't show me the ad even with all adblocks addons disabled) where there would be the 26th giveaway

Expected Behavior No breaks on page flow.

Console Errors

Screenshots

System (please complete the following information):

Additional Context the element is this(anything that might be some kind of id was changed to "???"):

<div style="padding-top: 35px; padding-bottom: 35px; border-bottom: 1px solid #d2d6e0; box-shadow: 0 1px 0 rgba(255,255,255,0.3);">
    <script async="" src="https://pagead2.googlesyndication.com/pagead/js/adsbygoogle.js"></script>
    <!-- sg_homepage_center_responsive -->
    <ins class="adsbygoogle" style="display: block; height: 0px;" data-ad-client="???" data-ad-slot="???" data-ad-format="auto" data-full-width-responsive="true" data-adsbygoogle-status="done">
        <ins id="aswift_0_expand" style="display: inline-table; border: medium none; height: 0px; margin: 0px; padding: 0px; position: relative; visibility: visible; width: 1013px; background-color: transparent;">
            <ins id="aswift_0_anchor" style="display: block; border: medium none; height: 0px; margin: 0px; padding: 0px; position: relative; visibility: visible; width: 1013px; background-color: transparent; overflow: hidden; opacity: 0;">
                <iframe id="aswift_0" name="aswift_0" style="left:0;position:absolute;top:0;border:0;width:1013px;height:280px;" src="https://googleads.g.doubleclick.net/pagead/ads????" marginwidth="0" marginheight="0" vspace="0" hspace="0" allowtransparency="true" scrolling="no" allowfullscreen="true" data-google-container-id="a!1" data-load-complete="true" data-google-query-id="???" tc-textcontent="true" data-tc-id="???" width="1013" height="280" frameborder="0"></iframe>
            </ins>
        </ins>
    </ins>
    <script>
        (adsbygoogle = window.adsbygoogle || []).push({});
    </script>
</div>

I blocked it on uBlock on the first 5 page when using gridview and endless scrolling using this rule (there probably is some better way):

edit:

datajosh's filters are way better than mine, check his comment for it.

rafaelgomesxyz commented 4 years ago

ESGST does not block ads, so what exactly are you requesting to be implemented here? Specially if uBlock already does that job.

marlop352 commented 4 years ago

was thinking of repositioning it below the giveaway list or something like that (I would rather not block the ads too, it was just the easiest/fastest for me)

edit: and I'm not sure its an ad as it just shows a blank space for me no matter how I open the page.

edit 2: found a browser that does load it, vivaldi, it is a ad. and a least one feature seems to block an ad (fixed sidebar), but I might be wrong on that.

rafaelgomesxyz commented 4 years ago

You're right, Fixed Sidebar hides the sidebar ad.

I guess I could move it below the giveaway list.

datajosh commented 4 years ago

Like @marlop352 said, there's probably a better way, but using these two filters in uBlock Origin catches it more often than the ones in the first post for me:

steamgifts.com##div[style="padding-top: 35px; padding-bottom: 35px; border-bottom: 1px solid #d2d6e0; box-shadow: 0 1px 0 rgba(255,255,255,0.3);"]
steamgifts.com##div[style="padding-top: 35px; padding-bottom: 35px; display: flex; justify-content: center; border-bottom: 1px solid #d2d6e0; box-shadow: 0 1px 0 rgba(255,255,255,0.3);"]
marlop352 commented 4 years ago

It also makes the counter on Displaying 1 to X counter below the giveaway list incorrect, and probably anything that counts those divs.

Eiion commented 4 years ago

Something new got added over night - now two ad boxes per page? These started showing up today (with the previously added ad boxes temporarily removed): Screenshot

@datajosh any suggestion for a filter as good as the one you've previously posted?

EDIT: This is what's working for me until they're all moved to under the giveaway listings:

steamgifts.com##div[style="max-width: 1000px; margin: 0 auto; padding-top: 35px; padding-bottom: 35px; border-bottom: 1px solid #d2d6e0; box-shadow: 0 1px 0 rgba(255,255,255,0.3);"]

(Offtopic, but how do I format text in markdown on github to get the horizontal scroll bar instead of a line break, just like in @datajosh's post?) (Offtopic edit: Seems link four spaces in front of the code does the trick.)

rafaelgomesxyz commented 4 years ago

What the hell is cg doing...

I'll see if I can add a filter to ESGST soon.

datajosh commented 4 years ago

@Eiion that was exactly the code I was coming here to post, that seems to be working for the moment, until SG changes something else at least

marlop352 commented 4 years ago

I'm not getting the extra div that @Eiion reported, the filters on the first comment of @datajosh still work for me.

datajosh commented 4 years ago

Can confirm what @marlop352 said. I disabled that last filter and the extra div isn't showing up anymore, no clue what's going on.